[squeak-dev] The Inbox: Installer-Core-cmm.428.mcz
Jakob Reschke
forums.jakob at resfarm.de
Mon Apr 8 12:29:51 UTC 2019
Am Mo., 8. Apr. 2019 um 13:57 Uhr schrieb Levente Uzonyi <
leves at caesar.elte.hu>:
> > ----- Method: Installer class>>ensureRecentMetacello (in category
> 'scripts') -----
> > ensureRecentMetacello
> > "Copied and adapted from
> https://github.com/Metacello/metacello/blob/master/README.md"
> >
> > | metacello |
> > ((Smalltalk classNamed: #WebClient)
> > ifNil: [ false ]
> > ifNotNil: [ :webClient |
> > [ (webClient httpHead: 'https://github.com')
> isSuccess ]
> > on: Error
> > do: [ false ] ])
> > ifFalse: [ ^self inform: 'Could not connect to "
> https://github.com".\\You need an internet connection and SSL support\to
> install (or update) Metacello.\\Please fix those issues and try again.'
> translated withCRs ].
> >
> > + metacello := Smalltalk classNamed: #Metacello.
> > + (metacello name = #Metacello) ifFalse: [
> > - metacello := (Smalltalk classNamed: #Metacello) ifNil: [
>
> This trick deserves a comment. It relies on the loose implementation of
> #classNamed: of Environment and existence of Object >> #name. Both of
> which I'd rather see changed.
>
metacello := Smalltalk classNamed: #Metacello.
metacello = MetacelloStub ifFalse: [
instead + a comment maybe?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20190408/44f64006/attachment.html>
More information about the Squeak-dev
mailing list
|