The code is actually intentionally formatted that way, because it
wants to be removed, its only there temporarily for a better UX.
Until FixUnderscores can be run on the mentioned class, I wished to
have that code set apart from the "normal" code.

I had considered using ensure: here, but decided it's not needed in
this context.  If there's an exception the user will have to either
abort the half-configured image or fix and force it through to
completion.


 - Chris



On Sun, Apr 21, 2019 at 9:13 PM Levente Uzonyi <leves at caesar.elte.hu> wrote:
>
> On Mon, 22 Apr 2019, commits at source.squeak.org wrote:
>
> snip
>
> > Item was changed:
> >  ----- Method: Installer class>>installGitInfrastructure (in category 'scripts') -----
> >  installGitInfrastructure
> > + | priorSetting |
> > + "for INIFileTest>>#testComplexRead"
> > + priorSetting := Scanner allowUnderscoreAsAssignment.
> > + Scanner allowUnderscoreAsAssignment: true.
> >
> > -     self ensureRecentMetacello.
> > -
> >       (Smalltalk at: #Metacello) new
> >                 baseline: 'Squot';
> >                 repository: 'github://hpi-swa/Squot:master/src';
> > +               load.
> > +
> > + Scanner allowUnderscoreAsAssignment: priorSetting
> > + !
> > -               load.!
>
> The method above lacks indentation and the setting should be restored with
> #ensure:. Also, that comment about INIFileTest doesn't make much sense.
>
> Levente
>