[squeak-dev] The Inbox: ToolBuilder-Morphic-ct.234.mcz

Marcel Taeumel marcel.taeumel at hpi.de
Tue Aug 6 07:22:37 UTC 2019


Hi Christoph,

this is not working. We have to support manual styling and cannot just remove text attributes there. Maybe if we check whether "styer" is set. Even then, we should follow the logic in PluggableTextMorphPlus >> #stylerStyled: to remove those text attributes.

Btw: You can style a piece of text manually via the context menu or [CMD]+[6..0].

Best,
Marcel
Am 05.08.2019 14:50:20 schrieb commits at source.squeak.org <commits at source.squeak.org>:
A new version of ToolBuilder-Morphic was added to project The Inbox:
http://source.squeak.org/inbox/ToolBuilder-Morphic-ct.234.mcz

==================== Summary ====================

Name: ToolBuilder-Morphic-ct.234
Author: ct
Time: 5 August 2019, 2:50:11.900062 pm
UUID: f6987fae-9cfa-4e44-927f-247f4eeb868e
Ancestors: ToolBuilder-Morphic-mt.233

Extend #updateStyle(Now) to remove obsolete styling

A call of #updateStyle(Now) implies that the text morph is used for styling, so it is not capable of storing other styles we could accidentally delete here.

=============== Diff against ToolBuilder-Morphic-mt.233 ===============

Item was changed:
----- Method: PluggableTextMorphPlus>>updateStyle (in category 'styling') -----
updateStyle

self okToStyle
+ ifTrue: [styler styleInBackgroundProcess: textMorph contents]
+ ifFalse: [textMorph contents: textMorph contents asString].!
- ifTrue: [styler styleInBackgroundProcess: textMorph contents].!

Item was changed:
----- Method: PluggableTextMorphPlus>>updateStyleNow (in category 'styling') -----
updateStyleNow

self okToStyle
+ ifTrue: [styler style: textMorph contents]
+ ifFalse: [textMorph contents: textMorph contents asString].!
- ifTrue: [styler style: textMorph contents].!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20190806/f367debc/attachment-0001.html>


More information about the Squeak-dev mailing list