[squeak-dev] The Trunk: ToolBuilder-Morphic-mt.235.mcz

Levente Uzonyi leves at caesar.elte.hu
Tue Aug 6 18:39:14 UTC 2019


Wouldn't it be better if there were only a single method:

updateStyle: inTheBackground

 	...

instead of duplicating the logic?


Levente

On Tue, 6 Aug 2019, commits at source.squeak.org wrote:

> Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk:
> http://source.squeak.org/trunk/ToolBuilder-Morphic-mt.235.mcz
>
> ==================== Summary ====================
>
> Name: ToolBuilder-Morphic-mt.235
> Author: mt
> Time: 6 August 2019, 8:50:12.289656 am
> UUID: 8fb2449e-5234-44cb-bba5-f7bcf80b3cef
> Ancestors: ToolBuilder-Morphic-ct.234
>
> Adds some comments.
>
> =============== Diff against ToolBuilder-Morphic-ct.234 ===============
>
> Item was changed:
>  ----- Method: PluggableTextMorphPlus>>updateStyle (in category 'styling') -----
>  updateStyle
> + 	"Be sure to reset the style if it is not #okToStyle. Models might just send 'self changed: #style' without resetting the contents. See #update:."
> + 
> -
>  	self okToStyle
>  		ifTrue: [styler styleInBackgroundProcess: textMorph contents]
>  		ifFalse: [textMorph contents: textMorph contents asString].!
>
> Item was changed:
>  ----- Method: PluggableTextMorphPlus>>updateStyleNow (in category 'styling') -----
>  updateStyleNow
> + 	"Be sure to reset the style if it is not #okToStyle. Models might just send 'self changed: #style' without resetting the contents. See #update:."
> + 
> -
>  	self okToStyle
>  		ifTrue: [styler style: textMorph contents]
>  		ifFalse: [textMorph contents: textMorph contents asString].!


More information about the Squeak-dev mailing list