[squeak-dev] The Inbox: Morphic-ct.1500.mcz

Thiede, Christoph Christoph.Thiede at student.hpi.uni-potsdam.de
Fri Aug 9 23:46:54 UTC 2019


Hi all,


is MenuMorph>>#filterListWith: still up to date? Has no senders (in my image) and looks like a duplicate of #handleFiltering:. But it does not display the filter.


Best,

Christoph

________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von commits at source.squeak.org <commits at source.squeak.org>
Gesendet: Samstag, 10. August 2019 01:43:38
An: squeak-dev at lists.squeakfoundation.org
Betreff: [squeak-dev] The Inbox: Morphic-ct.1500.mcz

A new version of Morphic was added to project The Inbox:
http://source.squeak.org/inbox/Morphic-ct.1500.mcz

==================== Summary ====================

Name: Morphic-ct.1500
Author: ct
Time: 10 August 2019, 1:43:30.153412 am
UUID: 3c117318-6d64-f14e-b166-ebee4ed792f7
Ancestors: Morphic-mt.1498

Refactor menu filtering to ignore special keys like Character end

=============== Diff against Morphic-mt.1498 ===============

Item was changed:
  ----- Method: MenuMorph>>handleFiltering: (in category 'keystroke helpers') -----
  handleFiltering: evt

         | matchString |
         matchString := self valueOfProperty: #matchString ifAbsentPut: [ String new ].
+        matchString := true
+                caseOf: {
+                        [ evt keyCharacter = Character backspace ] ->
+                                [ matchString isEmpty
+                                        ifTrue: [ matchString ]
+                                        ifFalse: [ matchString allButLast ] ].
+                        [ evt keyValue >= 32 ] ->
+                                [ matchString , evt keyCharacter ] }
+                otherwise: [ matchString ].
-        matchString := evt keyValue = 8 " Character backspace asciiValue "
-                ifTrue: [
-                        matchString isEmpty
-                                ifTrue: [ matchString ]
-                                ifFalse: [ matchString allButLast ] ]
-                ifFalse: [
-                        matchString copyWith: evt keyCharacter ].
         self setProperty: #matchString toValue: matchString.
         self displayFiltered: evt!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20190809/94aeede6/attachment-0001.html>


More information about the Squeak-dev mailing list