[squeak-dev] The Trunk: Tools-mt.864.mcz

Marcel Taeumel marcel.taeumel at hpi.de
Mon Aug 12 17:09:38 UTC 2019


Hi Jakob.

> This also does not work for RecentMessageSet, when a method in there was deleted again in the meantime. A KeyNotFound from compiledMethodAt: is the result.

It should. There is an #isValid check for all method references before opening the tool. See RecentMessageSet >> #reformulateList and RecentMessageSet #updateListsAndCodeIn:.

I fixed RecentMessages class >> #cleanUp: for that strange behavior, too. Does it still occur?
Am 10.08.2019 21:47:07 schrieb Jakob Reschke <forums.jakob at resfarm.de>:
Am So., 4. Aug. 2019 um 16:36 Uhr schrieb <commits at source.squeak.org [mailto:commits at source.squeak.org]>:

Marcel Taeumel uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-mt.864.mcz [http://source.squeak.org/trunk/Tools-mt.864.mcz]

==================== Summary ====================

Name: Tools-mt.864
Author: mt
Time: 4 August 2019, 4:36:12.203381 pm
UUID: cb8e1c1e-b28e-a647-a72e-1c49fe42bcc0
Ancestors: Tools-mt.856, Tools-mt.863

Merges and refines Tools-mt.856 based on the discussion on squeak-dev: http://forum.world.st/The-Inbox-Tools-mt-856-mcz-td5101574.html [http://forum.world.st/The-Inbox-Tools-mt-856-mcz-td5101574.html]

Note that if you notice any performance problems on slower machines, we might want to make this a preference.

=============== Diff against Tools-mt.863 ===============

Item was changed:
  ----- Method: Browser>>messageList (in category 'message list') -----
[...]

Item was added:
+ ----- Method: CodeHolder>>formattedLabel:forSelector:inClass: (in category 'message list') -----
+ formattedLabel: aString forSelector: aSymbol inClass: aClass
+       "Show deprecated messages differently so that users recognize them quickly to avoid them."
+       
+       | formattedLabel |
+       aSymbol = #Definition
+               ifTrue: [aClass isDeprecated not
+                       ifTrue: [^ aString]]
+               ifFalse: [(aClass compiledMethodAt: aSymbol) isDeprecated not



This also does not work for RecentMessageSet, when a method in there was deleted again in the meantime. A KeyNotFound from compiledMethodAt: is the result.

 
+                       ifTrue: [^ aString]].
+       
+       formattedLabel := aString asText.
+       
+       (self userInterfaceTheme deprecatedMessageAttributes ifNil: [{TextColor gray. TextEmphasis struckOut}]) do: [:textAttribute |
+               formattedLabel addAttribute: textAttribute].
+
+       ^ formattedLabel.!
[...]
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20190812/718ce30b/attachment.html>


More information about the Squeak-dev mailing list