[squeak-dev] The Trunk: Tools-mt.875.mcz

commits at source.squeak.org commits at source.squeak.org
Wed Aug 14 11:16:06 UTC 2019


Marcel Taeumel uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-mt.875.mcz

==================== Summary ====================

Name: Tools-mt.875
Author: mt
Time: 14 August 2019, 1:16:03.729512 pm
UUID: 6818d344-b9a1-ab49-bda7-a309a2e2c1c2
Ancestors: Tools-mt.874

Makes icons and dragging for deprecated messages work again. Hmm... it is really interesting to see how string-vs-text can blow up things.

Maybe use an approach similar to MessageSet class >> #parse:toClassAndSelector instead of #asString? There could be any fancy representation of a message in the message list.

=============== Diff against Tools-mt.874 ===============

Item was changed:
  ----- Method: Browser>>dragFromMessageList: (in category 'drag and drop') -----
  dragFromMessageList: index
  	"Drag a method from the browser"
+ 	
+ 	self flag: #refactor. "mt: Maybe use an approach similar to MessageSet class >> #parse:toClassAndSelector instead of #asString? There could be any fancy representation of a message in the message list."
+ 	^self selectedClassOrMetaClass compiledMethodAt: (self messageList at: index) asString ifAbsent:[nil]!
- 	^self selectedClassOrMetaClass compiledMethodAt: (self messageList at: index) ifAbsent:[nil]!

Item was changed:
  ----- Method: Browser>>messageIconAt: (in category 'message list') -----
  messageIconAt: anIndex
  
  	self class showMessageIcons ifFalse: [^ nil].
+ 	^ self messageIconFor: (self messageList at: anIndex ifAbsent: [^nil]) asString!
- 	^ self messageIconFor: (self messageList at: anIndex ifAbsent: [^nil])!

Item was changed:
  ----- Method: Browser>>messageListIndex: (in category 'message list') -----
  messageListIndex: anInteger
  	"Set the selected message selector to be the one indexed by anInteger."
  
+ 	self selectMessageNamed: (self messageList at: anInteger ifPresent: [:lbl | lbl asString] ifAbsent: [nil] )!
- 	self selectMessageNamed: (self messageList at: anInteger ifAbsent: [nil])!



More information about the Squeak-dev mailing list