[squeak-dev] The Inbox: ShoutCore-ct.69.mcz

Levente Uzonyi leves at caesar.elte.hu
Thu Aug 15 01:29:22 UTC 2019


On Wed, 14 Aug 2019, commits at source.squeak.org wrote:

> A new version of ShoutCore was added to project The Inbox:
> http://source.squeak.org/inbox/ShoutCore-ct.69.mcz
>
> ==================== Summary ====================
>
> Name: ShoutCore-ct.69
> Author: ct
> Time: 14 August 2019, 10:43:04.7164 pm
> UUID: 7d165f4e-09bf-a445-a664-5e8edb9867b8
> Ancestors: ShoutCore-ul.68
>
> Fix bug in SHParserST80: Wrong styling after blocks with arguments without statements

If you mean that Shout should accept [ :x ], then no, I'm pretty sure 
that's not valid smalltalk syntax, even if Parser accepts it.
The vertical bar, even though I consider it unnecessary in all cases, is 
mandatory when there are arguments.

Levente

>
> Thanks Jakob for the report!
>
> =============== Diff against ShoutCore-ul.68 ===============
>
> Item was changed:
>  ----- Method: SHParserST80>>parseBlockArguments (in category 'parse') -----
>  parseBlockArguments
>
>  	currentTokenFirst == $: ifFalse: [ ^self ].
>  	[ currentTokenFirst == $: ] whileTrue: [
>  		self
>  			scanPast: #blockArgColon;
>  			parseArgument: #blockPatternArg ].
> + 	((self parseVerticalBarForTemporaries: #blockArgsBar) and: [
> + 		currentTokenFirst ~= $] ])
> + 			ifFalse: [
> + 				self fail ": Missing block args bar" ]!
> - 	(self parseVerticalBarForTemporaries: #blockArgsBar) ifFalse: [
> - 		self fail ": Missing block args bar" ]!


More information about the Squeak-dev mailing list