[squeak-dev] The Trunk: KernelTests-nice.368.mcz

commits at source.squeak.org commits at source.squeak.org
Wed Aug 21 00:46:39 UTC 2019


Nicolas Cellier uploaded a new version of KernelTests to project The Trunk:
http://source.squeak.org/trunk/KernelTests-nice.368.mcz

==================== Summary ====================

Name: KernelTests-nice.368
Author: nice
Time: 21 August 2019, 2:46:11.211524 am
UUID: ecd4016f-706e-46c8-bf63-eef66063726d
Ancestors: KernelTests-mt.367

Illustrate issue with inexact mixed SmallInteger/Float comparison in Spur64

See https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/417

The issue only happen when code is jitted, so it might be necessary to tun the tests several times before seeing the failure.

=============== Diff against KernelTests-mt.367 ===============

Item was added:
+ ----- Method: SmallIntegerTest>>testCompareWithBoxedFloat (in category 'testing - Class Methods') -----
+ testCompareWithBoxedFloat
+ 	"In 64 bits, naive asFloat conversion should not be used"
+ 	
+ 	| bf sf si |
+ 	Smalltalk wordSize = 8 ifFalse: [^self].
+ 	si := 1<<(Float precision + 2)+1.
+ 	sf := si asFloat.
+ 	(bf := BoxedFloat64 new: 2) basicAt: 1 put: (sf basicAt: 1);basicAt: 2 put: (sf basicAt: 2).
+ 
+ 	self deny: si = bf.
+ 	self deny: bf = si.!

Item was added:
+ ----- Method: SmallIntegerTest>>testCompareWithSmallFloat (in category 'testing - Class Methods') -----
+ testCompareWithSmallFloat
+ 	"In 64 bits, naive asFloat conversion should not be used"
+ 	
+ 	| sf si |
+ 	Smalltalk wordSize = 8 ifFalse: [^self].
+ 	si := 1<<(Float precision + 2)+1.
+ 	sf := si asFloat.
+ 	self deny: sf = si.
+ 	self deny: si = sf.!



More information about the Squeak-dev mailing list