[squeak-dev] [Please Review] Many fixes for Morphic's layout

Fabio Niephaus lists at fniephaus.com
Wed Aug 21 14:58:01 UTC 2019


On Wed, 21 Aug 2019 at 4:58 pm, Marcel Taeumel <marcel.taeumel at hpi.de>
wrote:

> Please find attached an updated version.
>
> Biggest changes:
> - Fixes a bug with #cellInset in TableLayout
> - Adds new property *#cellGap* for TableLayout
>

+1 for calling this cellSpacing instead (similar to HTML tables).

- Uses #cellGap instead of #cellInset in most cases
>
>
> Best,
> Marcel
>
> Am 14.08.2019 08:51:29 schrieb Marcel Taeumel <marcel.taeumel at hpi.de>:
> Hey Chris (cmm) :-) Would you try it out on some important interactions in
> Maui?
>
> Hey Tim (tpr) :-) Would you make a short performance check on a
> RaspberryPi?
>
> Best,
> Marcel
>
> Am 12.08.2019 18:30:51 schrieb Marcel Taeumel <marcel.taeumel at hpi.de>:
> Hi, there,
>
> Please find attached a change set that addresses several bugs around
> layouting and re-drawing. I had the following goals:
>
> - Better support for *TextMorphs *in TableLayout
> - Better support for *protruding submorphs* in a non-clipping and
> non-shrink-wrapping morph
> - Ensure full layout computation after calling #fullBounds ... no extra
> re-draw cycles to *avoid flickering*.
>
> I have to admit that I did break some layout things back in 2016 because I
> didn't understand the implementation good enough. Other things have never
> been working correctly before, such as height-for-width updates for
> TextMorph children ... which do their own (text) layout and thus misbehaved
> in a table-layout container.
>
> What's (still) not working?
>
> - Useful *minimum extent* for windows and dialogs
> - *#justified* list-centering with #spaceFill children (-> might be a new
> issue but rare?)
>
> How can you test some changes? Well, try resizing the find-class or
> save-file dialog to this:
>
>
> Usually, submorphs are either not protruding their morphs or they get
> clipped. If they are protruding and not clipped, the layout-cell
> computation was a mix of bounds and fullBounds. I suppose that other
> frameworks use just the bounds, ignoring any protruding submorphs, like
> this:
>
>
> The blue-filled morphs are shrink-wrapped in a container arranged from the
> left to the right. Protruding submorphs share the owner's border color.
> Only the rightmost morph has its own table layout and adjuts its height to
> its children -- but not its width.
>
> Best,
> Marcel
>
>
>
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20190821/8909b619/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 22601 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20190821/8909b619/attachment.png>


More information about the Squeak-dev mailing list