[squeak-dev] [Discussion] Tools > "Metacello" and "Git Browser"

Marcel Taeumel marcel.taeumel at hpi.de
Mon Aug 26 12:10:05 UTC 2019

Hi, all!

You can also take a look at all senders of #windowColorToUse:

Hi, Dave. :-)

> Has anyone had a chance to look at Morphic-dtl.1506 in the inbox?

Not yet. Maybe later today.

Am 25.08.2019 22:26:11 schrieb David T. Lewis <lewis at mail.msen.com>:
On Sun, Aug 25, 2019 at 08:27:10PM +0200, Jakob Reschke wrote:
> Hi,
> I have never had a problem not specifying a default window color so far.
> And I use colorful windows all the time. What problem does it solve?
> Kind regards,
> Jakob

If you activate Extras -> Themes & Colors -> Colorful Windows to turn
on colorful winds, then the Tools menu entries will have colored box
icons to the left of each menu entry. The color of the box icon is
determined by defaultWindowColor for each tool. If no default color is
specified, then no colored box icon will be displayed in the Tools menu.

The earlier version of #gitInfrastructureMenuItemOn: that is in trunk
today did not honor window colors, instead it had hard-coded the menu
item color. I fixed this in my update, but in order for it to work
similarly to the other tool menu entries, it is necessary for the
tool (SqueakBrowser) to specify some window color other than the
default of Model>>#uniformWindowColor.

Note also that the current version in trunk is broken when colorful
windows is disabled. In that case, the git browser (and Metacello loader)
Tool menu entries will incorrectly display grey icons (but no icon
box should be displayed in this case).


> David T. Lewis schrieb am So., 25. Aug. 2019, 17:25:
> >
> > Menu icons are updated in the Tools menu, but note that the the Git
> > browser needs to have a #defaultWindowColor in order for colorful
> > windows
> > to work as expected. For example, add this in package Squit:
> >
> > SquitBrowser>>defaultWindowColor
> > ^ (Color r: 0.6 g: 0.7 b: 0.6)
> >


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20190826/a15243de/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 151672 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20190826/a15243de/attachment-0001.png>

More information about the Squeak-dev mailing list