[squeak-dev] [:x] considered improper (was Re: The Inbox: ShoutCore-ct.69.mcz)
tim at rowledge.org
Wed Aug 28 19:16:07 UTC 2019
At the last SOB meeting we agreed that we would prefer the standard be enforced and that [:x] be considered improper. Make it sew, Mr Tailor...
> On 2019-08-14, at 11:11 PM, Tobias Pape <Das.Linux at gmx.de> wrote:
>> On 15.08.2019, at 03:29, Levente Uzonyi <leves at caesar.elte.hu> wrote:
>> On Wed, 14 Aug 2019, commits at source.squeak.org wrote:
>>> A new version of ShoutCore was added to project The Inbox:
>>> ==================== Summary ====================
>>> Name: ShoutCore-ct.69
>>> Author: ct
>>> Time: 14 August 2019, 10:43:04.7164 pm
>>> UUID: 7d165f4e-09bf-a445-a664-5e8edb9867b8
>>> Ancestors: ShoutCore-ul.68
>>> Fix bug in SHParserST80: Wrong styling after blocks with arguments without statements
>> If you mean that Shout should accept [ :x ], then no, I'm pretty sure that's not valid smalltalk syntax, even if Parser accepts it.
>> The vertical bar, even though I consider it unnecessary in all cases, is mandatory when there are arguments.
> I only got to know this "shortcut syntax" because eliot used it either Cog or somewhere in trunk when preparing something (Spur? full block closures? I forgot). So this is a syntax idiosyncrasy that is in active use, not only "old code".
> Either we forbid it in the parser and change all of the image or allow it in Shout.
> Best regards
>>> Thanks Jakob for the report!
>>> =============== Diff against ShoutCore-ul.68 ===============
>>> Item was changed:
>>> ----- Method: SHParserST80>>parseBlockArguments (in category 'parse') -----
>>> currentTokenFirst == $: ifFalse: [ ^self ].
>>> [ currentTokenFirst == $: ] whileTrue: [
>>> scanPast: #blockArgColon;
>>> parseArgument: #blockPatternArg ].
>>> + ((self parseVerticalBarForTemporaries: #blockArgsBar) and: [
>>> + currentTokenFirst ~= $] ])
>>> + ifFalse: [
>>> + self fail ": Missing block args bar" ]!
>>> - (self parseVerticalBarForTemporaries: #blockArgsBar) ifFalse: [
>>> - self fail ": Missing block args bar" ]!
tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim
Strange OpCodes: IO: Illogical Or
More information about the Squeak-dev