What I find quite crazy, you can create a failure from this bug by opening a new ProcessBrowser and selecting "browse model class" from its morphic debug menu:


[cid:035b08ee-a762-465a-a9da-2a6c0c3709c9]


This is because the whole class lookup happens relative to the selection-dependent environment of the model instance.

Is this really what we want? Shouldn't these browse things maybe be implemented rather on models' class side?



And just another, a little bit related question: Are {SystemNavigation>>#browserClass[:], SystemBrowserClass>>#browserShowsPackagePane[:], BrowseTest.original[Hierarchy]BrowserClass} really in use anywhere, or should they be deprecated?


Best,

Christoph

________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von commits at source.squeak.org <commits at source.squeak.org>
Gesendet: Samstag, 7. Dezember 2019 17:03:06
An: squeak-dev at lists.squeakfoundation.org
Betreff: [squeak-dev] The Inbox: Tools-ct.924.mcz

A new version of Tools was added to project The Inbox:
http://source.squeak.org/inbox/Tools-ct.924.mcz

==================== Summary ====================

Name: Tools-ct.924
Author: ct
Time: 7 December 2019, 5:03:02.396431 pm
UUID: 0db76606-63d7-4a4a-94fd-99fe4a088304
Ancestors: Tools-mt.922

Fix a bug ProcessBrowser >> #selectedClass in case of no context selection

=============== Diff against Tools-mt.922 ===============

Item was changed:
  ----- Method: ProcessBrowser>>selectedClass (in category 'accessing') -----
  selectedClass
         "Answer the class in which the currently selected context's method was
         found."
         ^ selectedClass
+                ifNil: [
+                        selectedContext ifNil: [^ nil].
+                        selectedClass := selectedContext receiver
-                ifNil: [selectedClass := selectedContext receiver
                                 ifNil: [selectedSelector := selectedContext method selector.
                                            selectedContext method methodClass]
                                 ifNotNil: [selectedContext methodClass]]!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20191207/eff059f8/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pastedImage.png
Type: image/png
Size: 76395 bytes
Desc: pastedImage.png
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20191207/eff059f8/attachment-0002.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pastedImage.png
Type: image/png
Size: 76606 bytes
Desc: pastedImage.png
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20191207/eff059f8/attachment-0003.png>