Hi all!

Can I push this to Trunk to have a better image report for 5.3? Especially that bytecode-set encoder stuff... :-)



Best,
Marcel
Am 10.12.2019 15:59:41 schrieb commits at source.squeak.org <commits at source.squeak.org>:
A new version of SystemReporter was added to project The Inbox:
http://source.squeak.org/inbox/SystemReporter-mt.41.mcz

==================== Summary ====================

Name: SystemReporter-mt.41
Author: mt
Time: 10 December 2019, 3:59:34.438553 pm
UUID: 14618004-0dd4-2343-9469-2dd5aaddd38f
Ancestors: SystemReporter-eem.40

Updates image report.

=============== Diff against SystemReporter-eem.40 ===============

Item was added:
+ ----- Method: SystemReporter>>countUsesOfBytecodeSetEncoders (in category 'private') -----
+ countUsesOfBytecodeSetEncoders
+
+ | bag |
+ bag := Bag new.
+ CompiledMethod allInstancesDo: [:method |
+ bag add: method encoderClass].
+ ^ BytecodeEncoder allSubclasses collect: [:cls |
+ cls -> (bag occurrencesOf: cls)]!

Item was changed:
----- Method: SystemReporter>>reportImage: (in category 'reporting') -----
reportImage: aStream
+
+ | padding |
+ padding := 25.
self header: 'Image' on: aStream.
aStream
+ nextPutAll: ('Image name:' padded: #right to: padding with: Character space); nextPutAll: Smalltalk image imageName; cr;
+ nextPutAll: ('Image version:'padded: #right to: padding with: Character space); nextPutAll: SystemVersion current version; cr;
+ nextPutAll: ('Latest update:' padded: #right to: padding with: Character space); print: SystemVersion current highestUpdate; cr;
+ nextPutAll: ('Current change set:' padded: #right to: padding with: Character space); nextPutAll: ChangeSet current name; cr.
- nextPutAll: Smalltalk image imageName; cr;
- nextPutAll: SystemVersion current version; cr;
- nextPutAll: Smalltalk image lastUpdateString; cr;
- nextPutAll: Smalltalk image currentChangeSetString; cr.
[ | imageFormat bitsPerWord |
imageFormat := Smalltalk image imageFormatVersion.
bitsPerWord := Smalltalk image wordSize * 8.
+ aStream nextPutAll: ('Image format:' padded: #right to: padding with: Character space);
- aStream nextPutAll: 'Image format ';
nextPutAll: imageFormat asString;
nextPutAll: ' (';
nextPutAll: bitsPerWord asString;
nextPutAll: ' bit)'; cr]
on: Warning
do: ["primitive not present in VM"].
+ aStream nextPutAll: ('Preferred bytecode set:' padded: #right to: padding with: Character space);
+ print: CompiledCode preferredBytecodeSetEncoderClass;
+ cr.
+ self countUsesOfBytecodeSetEncoders do: [:encoderToCount |
+ aStream nextPutAll: ' Uses of ', (encoderToCount key name padded: #right to: padding with: Character space); space; print: encoderToCount value; cr].!
- !


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20191210/02d97a44/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 62530 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20191210/02d97a44/attachment-0001.png>