-1 for that change :-)


This commit makes it impossible to have multiple TestRunners opened side by side. For me, this is clearly a drawback. Why force unnecessary singletons?

In my opinion, the old implementation was simply correct - I can open as many TestRunners as I would like to do, but if there is already an open TestRunner with the same configuration, it will be focused instead.


> There's no way to spawn that model with any pre-selection


How do you mean this? Try the following - before loading this commit - line by line:

TestRunner openForSuite: StringTest suite.
TestRunner openForSuite: CharacterTest suite.
TestRunner openForSuite: StringTest suite.


Best,

Christoph

________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von commits at source.squeak.org <commits at source.squeak.org>
Gesendet: Samstag, 28. Dezember 2019 05:59:42
An: squeak-dev at lists.squeakfoundation.org; packages at lists.squeakfoundation.org
Betreff: [squeak-dev] The Trunk: SUnitGUI-cmm.78.mcz

Chris Muller uploaded a new version of SUnitGUI to project The Trunk:
http://source.squeak.org/trunk/SUnitGUI-cmm.78.mcz

==================== Summary ====================

Name: SUnitGUI-cmm.78
Author: cmm
Time: 27 December 2019, 10:59:41.297401 pm
UUID: 1c7d7b32-cdec-4875-80d8-7d2413e01a05
Ancestors: SUnitGUI-cmm.77

Fix TestRunner browser for use with Reuse Windows preference.  There's no way to spawn that model with any pre-selection, it's essentially a singleton browser in Squeak.

=============== Diff against SUnitGUI-cmm.77 ===============

Item was changed:
  ----- Method: TestRunner>>representsSameBrowseeAs: (in category 'accessing-ui') -----
  representsSameBrowseeAs: anotherModel
+        ^ true!
-        ^ self class = anotherModel class
-        and: [ classesSelected = anotherModel classesSelected ]!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20191228/8b691d0c/attachment.html>