Ah, thank you!


Then this can be moved to Treated.

________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Levente Uzonyi <leves at caesar.elte.hu>
Gesendet: Montag, 30. Dezember 2019 15:27:28
An: squeak-dev at lists.squeakfoundation.org
Betreff: Re: [squeak-dev] The Inbox: Collections-ct.870.mcz

On Mon, 30 Dec 2019, commits at source.squeak.org wrote:

> A new version of Collections was added to project The Inbox:
> http://source.squeak.org/inbox/Collections-ct.870.mcz
>
> ==================== Summary ====================
>
> Name: Collections-ct.870
> Author: ct
> Time: 30 December 2019, 3:01:24.515602 pm
> UUID: cb75296c-0850-d440-97a6-fc1962eef672
> Ancestors: Collections-nice.868
>
> Proposal: Refine Dictionary >> #at:ifPresent: not to require an one-arg block.
>
> Usage example:
>        Smalltalk at: className ifPresent: [self inform: 'Class already exists'. ^ nil].

That is what Dictionary >> #includesKey: is for:

         (Smalltalk includesKey: className) ifTrue: [self inform: 'Class already exists'. ^ nil].

Btw, classes should be looked up with #hasClassNamed::

         (Smalltalk hasClassNamed: className) ifTrue: [self inform: 'Class already exists'. ^ nil].


Levente

>
> =============== Diff against Collections-nice.868 ===============
>
> Item was changed:
>  ----- Method: Dictionary>>at:ifPresent: (in category 'accessing') -----
>  at: key ifPresent: aBlock
>        "Lookup the given key in the receiver. If it is present, answer the value of evaluating the given block with the value associated with the key. Otherwise, answer nil."
>
>        | v |
>        v := self at: key ifAbsent: [^ nil].
> +      ^ aBlock cull: v
> -      ^ aBlock value: v
>  !

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20191230/40d7ca69/attachment.html>