On Thu, 3 Jan 2019 at 13:05, tim Rowledge <tim at rowledge.org> wrote:

> Exception handling is fun!
>
> After some discussions at todays' SOB meeting, Eliot pointed out that we
> should be worrying about what the J20 standard says about exceptions.
> Interestingly, it explicitly calls out the sort of thing that
> NameLookupFailure>defaultAction does as wrong, with capital W and extra
> '!!'.


A quick search found this...
http://www.esug.org/data/Articles/AnsiSmalltalkStandard/STANDARD_V1_9.PDF
but I don't see "capital W and extra '!!'"

cheers -ben



> So, even though I found a slightly tacky work-around that appears to make
> it function most of the time, what we actually need to do is fix the real
> problem, ie bad code in some implementations of #defaultAction. And, maybe,
> comment a few places to help future-us get it right later.
>
> Looking at implementations of #defaultAction in the image I see the
> following in need of fixing -
>
> EnvironmentRequest>>#defaultAction
> FTPConnectionException>>#defaultAction
> InMidstOfFileinNotification>>#defaultAction
> MCProxyMaterialization>>#defaultAction
> NameLookupFailure>>#defaultAction
> OutOfScopeNotification>>#defaultAction
> ProgressInitiationException>>#defaultAction
> ProgressTargetRequestNotification>>#defaultAction
> ProjectEntryNotification>>#defaultAction
> ProjectPasswordNotification>>#defaultAction
> ProjectViewOpenNotification>>#defaultAction
> RequestAlternateSyntaxSetting>>#defaultAction (note that this was related
> to an ancient syntax experiment and the involved preference is no longer
> implemented and should be finally excised - see #printAlternateSyntax)
> WebAuthRequired>>#defaultAction
>
> tim
> --
> tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim
> Strange OpCodes: START: Cancel preceding jobs in queue
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20190103/ad6a96b8/attachment.html>