[squeak-dev] The Trunk: Monticello-tpr.693.mcz

Chris Muller asqueaker at gmail.com
Sat Jan 19 18:27:19 UTC 2019


The problem is you have your timeout set to low, not the server
not receiving the request.  Retry'ing doesn't make the initial request
come back any sooner, you're simply hammering the server with
duplicate request(s).

This code has today's date on it, did you test it?


On Fri, Jan 18, 2019 at 6:22 PM <commits at source.squeak.org> wrote:
>
> tim Rowledge uploaded a new version of Monticello to project The Trunk:
> http://source.squeak.org/trunk/Monticello-tpr.693.mcz
>
> ==================== Summary ====================
>
> Name: Monticello-tpr.693
> Author: tpr
> Time: 18 January 2019, 4:22:04.378573 pm
> UUID: bad22387-6176-41c3-9059-5a81199a26c7
> Ancestors: Monticello-tpr.692
>
> Allow up to 3 attempts to access the repository, to allow for network slowness etc. Pass the exception up if we still don't get what we want.
>
> =============== Diff against Monticello-tpr.692 ===============
>
> Item was changed:
>   ----- Method: MCHttpRepository>>readStreamForFileNamed:do: (in category 'private') -----
>   readStreamForFileNamed: aString do: aBlock
>
> +       | contents attempts|
> +       attempts := 0.
> +       self displayProgress: 'Downloading ', aString during: [
> +               [attempts := attempts + 1.
> +               contents := self httpGet: (self urlForFileNamed: aString) arguments: nil] on: NetworkError do: [:ex|
> +               attempts >= 3 ifTrue:[ex pass].
> +               ex retry ]].
> -       | contents |
> -       contents := self displayProgress: 'Downloading ', aString during: [
> -               self httpGet: (self urlForFileNamed: aString) arguments: nil ].
>         ^contents ifNotNil: [ aBlock value: contents ]!
>
>


More information about the Squeak-dev mailing list