[squeak-dev] The Inbox: Tools-ct.852.mcz

Marcel Taeumel marcel.taeumel at hpi.de
Tue Jul 2 07:00:19 UTC 2019


That's more direct that via a MessageSend. :-)

Am 01.07.2019 19:52:56 schrieb Levente Uzonyi <leves at caesar.elte.hu>:
On Mon, 1 Jul 2019, Christoph Thiede wrote:

> Hi Marcel,
> thanks for the reply! I'll be happy to add a callback within the next days.
> (Side question: Is there any reason why Symbol does not implement #valueWithPossibleArgs:? I think this could improve the code style of SimpleHierarchicalListMorph>>#keyStrokeAction: & Co.)

We have Object >> #perform:withEnoughArguments: for that purpose.


> Best,
> Christoph
> _________________________________________________________________________________________________________________________________________________________________________________________________________________________________
> Von: Squeak-dev im Auftrag von Marcel Taeumel
> Gesendet: Montag, 1. Juli 2019 09:13 Uhr
> An: Robert via Squeak-dev
> Betreff: Re: [squeak-dev] The Inbox: Tools-ct.852.mcz
> Hi Christoph,
> you could use the pattern for optional arguments in model callbacks such as in SimpleHierarchicalListMorph >> #keyStrokeAction: or EventHandler >> #send:to:withEvent:fromMorph:.
> Or, since #aboutToStyle: is a hard-coded callback, you could just support another hard-coded version: #aboutToStyle:fromMorph:. Check it with #respondsTo: such as in TextEditor >> #evaluateSelectionAndDo:.
> (In 2015, I removed the #respondsTo: check from PluggableTextMorphPlus >> #okToStyle:. Not sure why. Maybe performance reasons. I suppose that if a client configured #styler, that extra check felt unnecssary.)
> Best,
> Marcel
> Am 30.06.2019 22:26:29 schrieb Christoph Thiede :
> My desire was to activate styling in the Debugger's inspector panes for the
> case you type some expression into one of the panes. Unfortunately with this
> commit, each string representation of a selected instance/temporary var is
> styled as well. This is a general proposal about the Inspector: Do you think
> it would be a good idea to disable the styling when any variable is
> selected, and to activate it on any editText event?
> As far as I found out, there is no option to identify the relevant
> PluggableTextMorphPlus from #aboutToStyle:, so my only idea would be to
> remember the morph in an instvar of the Inspector and set its styler each
> time* to nil respectively a styler object. But that looks kind of hacky to
> myself ...
> *The styler would have to be updated in #toggleIndex: as well as in a
> selector like #editText:, where the latter does not exist yet.
> Do you think styling in Inspector would be worth these changes? Is there any
> better way to toggle styling (but looking at Workspace>>#toggleStyling, I do
> not think so)? Or would it even be worth thinking about introducing a custom
> selector to be called in PluggableTextMorphPlus>>#okToStyle?
> I would be glad about any advices!
> --
> Sent from: http://forum.world.st/Squeak-Dev-f45488.html
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20190702/bb5074e4/attachment.html>

More information about the Squeak-dev mailing list