Oha! Now I am seeing the 5. :-D

Thanks,
Marcel
Am 05.07.2019 00:32:53 schrieb Eliot Miranda <eliot.miranda at gmail.com>:
Hi Marcel,



On Jul 4, 2019, at 5:04 AM, Marcel Taeumel <marcel.taeumel at hpi.de [mailto:marcel.taeumel at hpi.de]> wrote:


Hi all!

The test CompilerTest >> #testMaxLiteralsWithClassReferenceInClosure fails for V3PlusClosures. It is off by 5 literals.

Could it be because V3PlusClosures inlines blocks in the same compiled method but SistaV1 extracts them into an extra compiled block?

Almost certainly.  Use the explore view to verify.


I was wondering whether that "[ DateAndTime now. Date today. Time ]." accounts for 5 literals ... even though I am only seeing 4. :-)

It should indeed be 5.  Weird :-)


Any thoughts?

Best,
Marcel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20190705/cf89b2a6/attachment.html>