Hi, there.

Thanks for finding this! +1

Are there more places where CurrentReadOnlySourceFiles >> #cacheDuring: should be used? How to find out?

Best,
Marcel
Am 12.06.2019 17:59:59 schrieb commits at source.squeak.org <commits at source.squeak.org>:
Patrick Rein uploaded a new version of Traits to project The Inbox:
http://source.squeak.org/inbox/Traits-pre.312.mcz

==================== Summary ====================

Name: Traits-pre.312
Author: pre
Time: 12 June 2019, 5:59:48.264868 pm
UUID: f2ec63fa-f6e8-0347-a2c6-fb8623cb4a92
Ancestors: Traits-nice.311

This speeds up the compilation of methods in traits or in classes using traits by caching subsequent reads to the changes file.

=============== Diff against Traits-nice.311 ===============

Item was changed:
----- Method: ClassDescription>>updateTraits (in category '*Traits-NanoKernel') -----
updateTraits
"Recompute my local traits composition"
+ CurrentReadOnlySourceFiles cacheDuring: [
+ self installTraitsFrom: self traitComposition]!
- self installTraitsFrom: self traitComposition.
- !

Item was changed:
----- Method: TraitDescription>>addSelectorSilently:withMethod: (in category 'operations') -----
addSelectorSilently: selector withMethod: compiledMethod
"Overridden to update the users of this trait"
+ CurrentReadOnlySourceFiles cacheDuring: [
+ super addSelectorSilently: selector withMethod: compiledMethod.
+ self users do:[:each| each updateTraits]]!
- super addSelectorSilently: selector withMethod: compiledMethod.
- self users do:[:each| each updateTraits].!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20190613/9c474048/attachment.html>