[squeak-dev] The Inbox: Morphic-sjce.1465.mcz
Levente Uzonyi
leves at caesar.elte.hu
Thu Mar 21 23:54:13 UTC 2019
Do you have a reproducible case fixed by this commit?
To me it seems to be a workaround for a mistake: a morph's name is a
Text instead of a String.
Levente
On Thu, 21 Mar 2019, commits at source.squeak.org wrote:
> A new version of Morphic was added to project The Inbox:
> http://source.squeak.org/inbox/Morphic-sjce.1465.mcz
>
> ==================== Summary ====================
>
> Name: Morphic-sjce.1465
> Author: sjce
> Time: 21 March 2019, 10:43:01.809481 pm
> UUID: f283ce64-3557-483a-971f-43ad678deef9
> Ancestors: Morphic-eem.1464
>
> Trying to open the debugger halo on the resulting window results in a MNU
> Text>>truncateWithElipsisTo: in HaloMorph>>doDebug:with:
>
> Trying to grab the window results in a MNU Text>>truncateTo:
> in Morph>>nameForUndoWording that needs a similar change
>
> =============== Diff against Morphic-eem.1464 ===============
>
> Item was changed:
> ----- Method: HaloMorph>>doDebug:with: (in category 'private') -----
> doDebug: evt with: menuHandle
> "Ask hand to invoke the a debugging menu for my inner target. If shift key is down, immediately put up an inspector on the inner target"
>
> | menu |
> evt shiftPressed ifTrue: [
> evt hand removeHalo.
> ^ innerTarget inspectInMorphic: evt].
>
> menu := innerTarget buildDebugMenu: evt hand.
> + menu addTitle: (innerTarget externalName asString truncateWithElipsisTo: 40).
> - menu addTitle: (innerTarget externalName truncateWithElipsisTo: 40).
> menu popUpEvent: evt in: self world.
> evt hand removeHalo.!
>
> Item was changed:
> ----- Method: Morph>>nameForUndoWording (in category 'dropping/grabbing') -----
> nameForUndoWording
> "Return wording appropriate to the receiver for use in an undo-related menu item (and perhaps elsewhere)"
>
> | aName |
> aName := self knownName ifNil: [self renderedMorph class name].
> + ^ aName asString truncateTo: 24!
> - ^ aName truncateTo: 24!
More information about the Squeak-dev
mailing list
|