[squeak-dev] The Inbox: Morphic-sjce.1465.mcz
Tobias Pape
Das.Linux at gmx.de
Mon Mar 25 09:29:11 UTC 2019
Hi all
> On 25.03.2019, at 09:52, Marcel Taeumel <marcel.taeumel at hpi.de> wrote:
>
> Hi Eliot,
>
> yes, I would also prefer inheritance (e.g. CharacterArray between ArrayedCollection and String/Text) over MNU.
If we go that way, lets do it slightly GemStone-compatible where (for other reasons, admittedly) String inherits from
CharacterCollection
(which is a SequenceableCollection).
I say slightly, because actually, Text there inherits from ArrayedCollection from when Dale ported that from Squeak to GemStone…
Best regards
-Tobias
>
> Best,
> Marcel
>> Am 22.03.2019 15:37:02 schrieb Eliot Miranda <eliot.miranda at gmail.com>:
>>
>>
>> On Mar 22, 2019, at 12:19 AM, Marcel Taeumel <marcel.taeumel at hpi.de> wrote:
>>
>>> Hi, there.
>>>
>>> Can we find better ways for supporting String protocols in Text objects? Maybe through DNU?
>>
>> Look at VisualWorks. I can’t remember how it’s solved there but it’s way better than Squeak. I *think* it introduces an abstract class CharacterArray above String & Text and moves as much protocol there as possible. MNU would be a horrible approach IMO.
>>
>>>
>>> Best,
>>> Marcel
>>>> Am 21.03.2019 22:43:16 schrieb commits at source.squeak.org <commits at source.squeak.org>:
>>>>
>>>> A new version of Morphic was added to project The Inbox:
>>>> http://source.squeak.org/inbox/Morphic-sjce.1465.mcz
>>>>
>>>> ==================== Summary ====================
>>>>
>>>> Name: Morphic-sjce.1465
>>>> Author: sjce
>>>> Time: 21 March 2019, 10:43:01.809481 pm
>>>> UUID: f283ce64-3557-483a-971f-43ad678deef9
>>>> Ancestors: Morphic-eem.1464
>>>>
>>>> Trying to open the debugger halo on the resulting window results in a MNU
>>>> Text>>truncateWithElipsisTo: in HaloMorph>>doDebug:with:
>>>>
>>>> Trying to grab the window results in a MNU Text>>truncateTo:
>>>> in Morph>>nameForUndoWording that needs a similar change
>>>>
>>>> =============== Diff against Morphic-eem.1464 ===============
>>>>
>>>> Item was changed:
>>>> ----- Method: HaloMorph>>doDebug:with: (in category 'private') -----
>>>> doDebug: evt with: menuHandle
>>>> "Ask hand to invoke the a debugging menu for my inner target. If shift key is down, immediately put up an inspector on the inner target"
>>>>
>>>> | menu |
>>>> evt shiftPressed ifTrue: [
>>>> evt hand removeHalo.
>>>> ^ innerTarget inspectInMorphic: evt].
>>>>
>>>> menu := innerTarget buildDebugMenu: evt hand.
>>>> + menu addTitle: (innerTarget externalName asString truncateWithElipsisTo: 40).
>>>> - menu addTitle: (innerTarget externalName truncateWithElipsisTo: 40).
>>>> menu popUpEvent: evt in: self world.
>>>> evt hand removeHalo.!
>>>>
>>>> Item was changed:
>>>> ----- Method: Morph>>nameForUndoWording (in category 'dropping/grabbing') -----
>>>> nameForUndoWording
>>>> "Return wording appropriate to the receiver for use in an undo-related menu item (and perhaps elsewhere)"
>>>>
>>>> | aName |
>>>> aName := self knownName ifNil: [self renderedMorph class name].
>>>> + ^ aName asString truncateTo: 24!
>>>> - ^ aName truncateTo: 24!
>>>>
>>>>
>>>
>
More information about the Squeak-dev
mailing list
|