[squeak-dev] The Trunk: PreferenceBrowser-mt.85.mcz

commits at source.squeak.org commits at source.squeak.org
Tue May 21 09:35:05 UTC 2019

Marcel Taeumel uploaded a new version of PreferenceBrowser to project The Trunk:

==================== Summary ====================

Name: PreferenceBrowser-mt.85
Author: mt
Time: 21 May 2019, 11:35:06.795219 am
UUID: 6624fa05-6f97-3742-81a5-50c106c92e33
Ancestors: PreferenceBrowser-eem.84

Fixes the visuals for halo-radio buttons in the preference browser.

=============== Diff against PreferenceBrowser-eem.84 ===============

Item was changed:
  ----- Method: PBHaloThemePreferenceView>>haloThemeRadioButtons (in category 'user interface') -----
  	"Answer a column of butons representing the choices of halo theme"
  	| buttonColumn |
  	buttonColumn := self verticalPanel.
  	#(	(iconicHaloSpecifications iconic iconicHalosInForce	'circular halos with icons inside')
  		(classicHaloSpecs	classic	classicHalosInForce		'plain circular halos')
  		(simpleFullHaloSpecifications		simple	simpleHalosInForce	'fewer, larger halos')
  		(customHaloSpecs	custom	customHalosInForce		'customizable halos')) do:
  		[:quad |
+ 			| aRadioButton  |
- 			| aRow aRadioButton aLabel |
  			aRadioButton := UpdatingThreePhaseButtonMorph radioButton
  				target: Preferences;
  				setBalloonText: quad fourth;
  				actionSelector: #installHaloTheme:;
  				getSelector: quad third;
  				arguments: (Array with: quad first);
+ 				label: quad second asString;
+ 			buttonColumn addMorphBack: aRadioButton].
- 			aLabel := (StringMorph contents: quad second asString)
- 						setBalloonText: quad fourth;
- 						yourself.
- 			aRow := self horizontalPanel
- 				cellInset: 4;
- 				addMorphBack: aRadioButton;
- 				addMorphBack: aLabel.
- 			buttonColumn addMorphBack: aRow].
  	^ buttonColumn
  	"(Preferences preferenceAt: #haloTheme) view tearOffButton"!

Item was changed:
  ----- Method: PBHaloThemePreferenceView>>representativeButtonWithColor:inPanel: (in category 'user interface') -----
  representativeButtonWithColor: aColor inPanel: aPreferencesPanel
  	| innerPanel |
+ 	innerPanel := self horizontalFiller
+ 		addMorphBack: self horizontalFiller;
- 	innerPanel := self horizontalPanel
- 		addMorphBack: (self blankSpaceOf: 10 at 0);
  		addMorphBack: self haloThemeRadioButtons;
  	^self verticalPanel
  		color: aColor;
  		layoutInset: 2;
  		addMorphBack: self morphForName;
  		addMorphBack: innerPanel.!

More information about the Squeak-dev mailing list