> ...  but one thing I've begun doing lately is, when I introduce an accessor _only_ because of printing, I've been starting it out in 'printing' too, for ease of collecting "related methods" together.

That's a good first step. However, as soon as in Trunk (or shipped for that matter), I suppose that -- for the users -- the class itself will become the first, obvious relationship for its methods. And putting it in "accessing" might also transport the information that it is actually usable in public and not like "private use for printing only".

Here is a small anecdote:

A: "Oh, you used #x instead of #position. That explains the strange behavior."
B: "Why is that?"
A: "It is in the Etoys category. Etoys uses a different coordinate system."
B: "Aha, I did not see that. Just stumbled upon #x and thought that it fits well for the morph's coordinates."

The end. :-)

Best,
Marcel
Am 06.11.2019 01:13:48 schrieb Chris Muller <asqueaker at gmail.com>:
Thanks for the code review.   Updated version in Collections-cmm.859.mcz.

-1 for choosing 'printing' as category of #keysInOrder (and #keysSortedSafely). Maybe 'accessing' instead?

Sure.  I actually did think about that, but one thing I've begun doing lately is, when I introduce an accessor _only_ because of printing, I've been starting it out in 'printing' too, for ease of collecting "related methods" together.

But, I think you're right that these could be useful accessors beyond printing (serialization?).  I moved them.
 
-1 for not having a comment in #keysInOrder ... could you explain the idea of "order" in contrast to "as is" with just a few words? :-) So that one can figure out when to use #keysSortedSafely and when to pick #keysInOrder

Hmmm... does "keys in order" sound almost like "are keys in order" and thus like a boolean result? I have no idea. :-D Did you also consider "keysOrdered" or "orderedKeys"? Just thinking about Color class >> #orderedCrayonColors.

Okay.

Thanks,
  Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20191106/fc4fbe27/attachment-0001.html>