Hi all, I think we have a problem with Text>>#unembellished. By looking at its name, I would have assumed that this method checks whether a text has not any (visible) attributes. But actually, it checks whether the text has no other attributes than the default font and TextEmphasis bold!


I think this is a misleading name. It causes an actual bug when you try to accept a HelpTopic which only contains bold formatting. In this case, the emphasis is not preserved ...


What is the history of #unembellished? I suspect it comes from times where we didn't have shout but only formatted method headers that should not be stored into the methodSource. Am I correct?

The related preference #ignoreStyleIfOnlyBold also only has one sender, #unembellished. I would propose to ignore that preference and deprecate it. Any opinions? :-)


Best,

Christoph
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20191115/cd8f6ee7/attachment.html>