[squeak-dev] The Trunk: ShoutCore-eem.75.mcz

Marcel Taeumel marcel.taeumel at hpi.de
Tue Oct 8 06:59:08 UTC 2019


>  Shout was never intended to work with Text objects.

+1

> ... fix the place that started introducing Texts as source.

+1

Best,
Marcel
Am 07.10.2019 23:47:40 schrieb Levente Uzonyi <leves at caesar.elte.hu>:
On Mon, 7 Oct 2019, commits at source.squeak.org wrote:

> Eliot Miranda uploaded a new version of ShoutCore to project The Trunk:
> http://source.squeak.org/trunk/ShoutCore-eem.75.mcz
>
> ==================== Summary ====================
>
> Name: ShoutCore-eem.75
> Author: eem
> Time: 7 October 2019, 12:10:14.151324 pm
> UUID: c899dcab-f05f-48a5-b7e8-e1b442163e6a
> Ancestors: ShoutCore-ct.74
>
> Make sure SHParserST80's source is a string. various malfunctions can occur if it is a text.

The type information in the variable name was correct. Shout was never
intended to work with Text objects. I see where those Text objects got
into the parser, so if you don't mind, I'll revert this and fix the place
that started introducing Texts as source.

Levente

>
> =============== Diff against ShoutCore-ct.74 ===============
>
> Item was changed:
> ----- Method: SHParserST80>>source: (in category 'accessing') -----
> + source: aStringOrText
> - source: aString
>
> + source := aStringOrText asString!
> - source := aString
> - !

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20191008/20739182/attachment.html>


More information about the Squeak-dev mailing list