Well, after Tools-ct.900, there is only one #mainFieldListMenu: implementation :)


What about Browser>>classListMenu:? This one is quite small.

________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel
Gesendet: Montag, 7. Oktober 2019 09:03:14
An: Alan Grimes via Squeak-dev
Betreff: Re: [squeak-dev] The Inbox: Help-Squeak-Project-ct.70.mcz

Hmm... I prefer the pointer to DictionaryInspector because its a "more basic" tool.

DictionaryInspector specializes Inspector for Dictionaries. ObjectExplorer is a more heavy-weight way to take a look at objects, compared to Inspector. So, ObjectExplorer should re-use things from Inspector. ObjectExplorer already holds an instance of Inspector. ... which is not even used anymore! So we copied all that stuff over? Hmmm...

There are also more implementors of #mainFieldListMenu: than of #mainTreeListMenu:. :-)

Best,
Marcel

Am 03.10.2019 02:24:52 schrieb commits at source.squeak.org <commits at source.squeak.org>:

A new version of Help-Squeak-Project was added to project The Inbox:
http://source.squeak.org/inbox/Help-Squeak-Project-ct.70.mcz

==================== Summary ====================

Name: Help-Squeak-Project-ct.70
Author: ct
Time: 3 October 2019, 2:24:48.841682 am
UUID: 1b5d8124-e6b0-4b43-9e35-dc3d47ea06c9
Ancestors: Help-Squeak-Project-mt.69

Complements Tools-ct.900 (Inspector refactoring)

Just use refer to another menu that is more suitable as an example :)

=============== Diff against Help-Squeak-Project-mt.69 ===============

Item was changed:
----- Method: SqueakMessageCategoriesHelp>>menu (in category 'menu') -----
menu
"This category includes all methods related to menus, often context menus in particular. It contains methods defining the menu as well as often callbacks for the labels of menu items or the actions to be executed. Sometimes the menus are split up in different categories if there are multiple menus or submenus."

+ ^ {ObjectExplorer>>#mainTreeListMenu: . SystemWindow>>#makeClosable}!
- ^ {DictionaryInspector>>#mainFieldListMenu: . SystemWindow>>#makeClosable}!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20191013/72daa877/attachment.html>