Thank you :)


A very minor question: Would you favor [self basicNew] over [super new]? It will work completely equivalently, but what is the better style?


Christoph

________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von commits at source.squeak.org <commits at source.squeak.org>
Gesendet: Montag, 2. September 2019 11:43:30
An: squeak-dev at lists.squeakfoundation.org; packages at lists.squeakfoundation.org
Betreff: [squeak-dev] The Trunk: Collections-mt.851.mcz

Marcel Taeumel uploaded a new version of Collections to project The Trunk:
http://source.squeak.org/trunk/Collections-mt.851.mcz

==================== Summary ====================

Name: Collections-mt.851
Author: mt
Time: 2 September 2019, 11:43:25.156478 am
UUID: f2b64324-98fe-5846-8e48-cfc0a1481b61
Ancestors: Collections-ct.850

Merges Collections-ct.829, which I moved to treated inbox due to incompatible ancestry.

"Refactor Matrix instance creation: Matrix new returns a valid (empty) matrix instead of an uninitialized object"

=============== Diff against Collections-ct.850 ===============

Item was added:
+ ----- Method: Matrix class>>new (in category 'instance creation') -----
+ new
+        ^self rows: 0 columns: 0!

Item was changed:
  ----- Method: Matrix class>>rows:columns:contents: (in category 'private') -----
  rows: rows columns: columns contents: contents
+        ^super new rows: rows columns: columns contents: contents!
-        ^self new rows: rows columns: columns contents: contents!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20190904/711a11d2/attachment.html>