[squeak-dev] The Trunk: Kernel-eem.1265.mcz

Marcel Taeumel marcel.taeumel at hpi.de
Fri Sep 6 06:14:17 UTC 2019


Hi Eliot,

please take a look at Kernel-mt.1266 in the inbox:
http://forum.world.st/The-Inbox-Kernel-mt-1266-mcz-td5103352.html [http://forum.world.st/The-Inbox-Kernel-mt-1266-mcz-td5103352.html]

Do you need #messagesSequence
   (a) to only scan that specific code object or
   (b) to you want it for a compiled method, traversing all embedded compiled blocks? (SistaV1)

Best,
Marcel
Am 06.09.2019 07:52:05 schrieb Marcel Taeumel <marcel.taeumel at hpi.de>:
Aha! :-) Thanks for pointing that out. ;-)

Best,
Marcel
Am 05.09.2019 18:45:01 schrieb commits at source.squeak.org <commits at source.squeak.org>:
Eliot Miranda uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-eem.1265.mcz

==================== Summary ====================

Name: Kernel-eem.1265
Author: eem
Time: 5 September 2019, 9:44:47.807982 am
UUID: 69e1a0f1-43f5-435e-999d-b8e81b52401a
Ancestors: Kernel-mt.1264

Fix a regression in COmpiledMethod>>messagesSequence caused by the method not having been correctly commented in the first place.

=============== Diff against Kernel-mt.1264 ===============

Item was added:
+ ----- Method: CompiledCode>>messagesSequence (in category 'scanning') -----
+ messagesSequence
+ "Answer a sequence of all the message selectors sent by this method in the order
+ they are sent. Unlike messages this may include duplicates."
+
+ ^Array streamContents:
+ [:str| | scanner |
+ scanner := InstructionStream on: self.
+ scanner scanFor:
+ [:x | | selectorOrSelf |
+ (selectorOrSelf := scanner selectorToSendOrSelf) == scanner ifFalse:
+ [str nextPut: selectorOrSelf].
+ false "keep scanning"]]!

Item was removed:
- ----- Method: CompiledMethod>>messagesSequence (in category 'scanning') -----
- messagesSequence
-
- self flag: #todo. "mt: Better change #messages to return an array instead of a set?"
- ^ self messages asArray!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20190906/3f7699bf/attachment.html>


More information about the Squeak-dev mailing list