Wouldn't it be nicer if it simply always measured, and we left the API
clean?


On Mon, Sep 9, 2019 at 12:03 PM Jakob Reschke <forums.jakob at resfarm.de>
wrote:

> runSuiteAndMeasureTime:?
>
> <commits at source.squeak.org> schrieb am Mo., 9. Sep. 2019, 16:40:
>
>> A new version of SUnitGUI was added to project The Inbox:
>> http://source.squeak.org/inbox/SUnitGUI-mt.74.mcz
>>
>> ==================== Summary ====================
>>
>> Name: SUnitGUI-mt.74
>> Author: mt
>> Time: 9 September 2019, 4:40:33.402661 pm
>> UUID: 99859e65-22a5-4b93-9876-8bb1dcd3cc39
>> Ancestors: SUnitGUI-mt.73
>>
>> Adds time measurement for tests without changing TestCase, which is
>> important for smalltalkCi.
>>
>> We still need terminology better than "measured" ... :-)
>>
>> =============== Diff against SUnitGUI-mt.73 ===============
>>
>> Item was changed:
>>   ----- Method: TestRunner>>buttons (in category 'accessing-ui') -----
>>   buttons
>> +       ^ #(( 'Run Selected' #runAllMeasured #hasRunnable )
>> -       ^ #(( 'Run Selected' #runAll #hasRunnable )
>>                 ( 'Run Profiled' #runProfiled #hasRunnable )
>>                 ( 'Run Coverage' #runCoverage #hasRunnable )
>>                 ( 'Run Failures' #runFailures #hasFailures )
>>                 ( 'Run Errors' #runErrors #hasErrors ))!
>>
>> Item was added:
>> + ----- Method: TestRunner>>runAllMeasured (in category 'actions -
>> measured') -----
>> + runAllMeasured
>> +
>> +       self
>> +               reset;
>> +               runSuiteMeasured: self suiteAll;
>> +               saveResultInHistory.!
>>
>> Item was added:
>> + ----- Method: TestRunner>>runSuiteMeasured: (in category 'actions -
>> measured') -----
>> + runSuiteMeasured: aTestSuite
>> +       self basicRunSuite: aTestSuite do: [ :each | self
>> runTestMeasured: each ].
>> +       self updateResults
>> +
>> + !
>>
>> Item was added:
>> + ----- Method: TestRunner>>runTestMeasured: (in category 'actions -
>> measured') -----
>> + runTestMeasured: aTestCase
>> +       result runCaseMeasured: aTestCase.
>> +       self updateStatus: true.!
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20190909/a2094012/attachment.html>