[squeak-dev] The Trunk: Tools-eem.959.mcz

commits at source.squeak.org commits at source.squeak.org
Wed Apr 15 23:12:22 UTC 2020


Eliot Miranda uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-eem.959.mcz

==================== Summary ====================

Name: Tools-eem.959
Author: eem
Time: 15 April 2020, 4:12:17.416699 pm
UUID: 60d7efe0-296a-4127-9b50-6e8d701cf715
Ancestors: Tools-mt.958

Change a method to use selectorsDo:; messagesDo: should be deprecated at some point.

=============== Diff against Tools-mt.958 ===============

Item was changed:
  ----- Method: Behavior>>toolIconSelector: (in category '*Tools-icons') -----
  toolIconSelector: aSymbol
  	"Tools can annotate the method identified by aSymbol with an icon identified by the symbol this method returns.
  	We customize this for, eg, overriden methods or methods with breaks.
  	Defaults to no icon"
  
  	self methodDictionary at: aSymbol ifPresent: [ :method |
  		method hasBreakpoint ifTrue: [^ #breakpoint].
+ 		method selectorsDo: [:messageSelector |
- 		method messagesDo: [:messageSelector |
  			(#(halt halt: haltIfNil haltIf: haltOnce haltOnce: haltOnCount: halt:onCount: break) includes: messageSelector)
  				ifTrue: [^ #breakpoint].
  			(#(flag: needsWork notYetImplemented) includes: messageSelector)
  				ifTrue: [^ #flag].
  			(#(shouldBeImplemented subclassResponsibility) includes: messageSelector)
  				ifTrue: [
  					(self isSelectorOverridden: aSymbol)
  						ifTrue: [^ #abstract]
  						ifFalse: [^ #notOverridden]].
  			messageSelector == #shouldNotImplement
  				ifTrue: [^ #no]].
  		method hasReportableSlip ifTrue: [^ #breakpoint]].
  		
  	(self isSelectorOverride: aSymbol)
  		ifTrue: [
  			(self isSelectorOverridden: aSymbol)
  				ifTrue: [ ^ #arrowUpAndDown ]
  				ifFalse: [ ^ #arrowUp ] ]
  		ifFalse: [
  			(self isSelectorOverridden: aSymbol)
  				ifTrue: [^ #arrowDown ]].
  
  	self methodDictionary at: aSymbol ifPresent: [ :method |
  		(method primitive ~= 0 and: [method isQuick not])
  			ifTrue: [^ #primitive]].
  	
  
  	^ #blank!



More information about the Squeak-dev mailing list