[squeak-dev] The Inbox: MonticelloConfigurations-dtl.166.mcz

commits at source.squeak.org commits at source.squeak.org
Sat Apr 18 02:20:23 UTC 2020


A new version of MonticelloConfigurations was added to project The Inbox:
http://source.squeak.org/inbox/MonticelloConfigurations-dtl.166.mcz

==================== Summary ====================

Name: MonticelloConfigurations-dtl.166
Author: dtl
Time: 17 April 2020, 10:19:48.245301 pm
UUID: 796ad747-3ca0-4613-a5d7-25fcfd294976
Ancestors: MonticelloConfigurations-dtl.165

Provide a proper editor dialog for the MCM version comment entry as part of the MCConfigurationBrowser store operation.

=============== Diff against MonticelloConfigurations-dtl.165 ===============

Item was changed:
  MCTool subclass: #MCConfigurationBrowser
+ 	instanceVariableNames: 'configuration dependencyIndex repositoryIndex activeEditWindow'
- 	instanceVariableNames: 'configuration dependencyIndex repositoryIndex'
  	classVariableNames: ''
  	poolDictionaries: ''
  	category: 'MonticelloConfigurations'!
  
  !MCConfigurationBrowser commentStamp: 'dtl 5/10/2010 21:48' prior: 0!
  A MCConfigurationBrowser displays an MCConfiguration, and edits the configuration to add or remove package dependencies and repository specifications. It allows a configuration to be stored in a repository or posted to an update stream.!

Item was added:
+ ----- Method: MCConfigurationBrowser>>activeEditWindow: (in category 'morphic ui') -----
+ activeEditWindow: editWindow
+ 	"Set temporarily during the process of editing a version comment."
+ 	activeEditWindow ifNotNil: [:window | window delete].
+ 	activeEditWindow := editWindow.
+ !

Item was added:
+ ----- Method: MCConfigurationBrowser>>completeStoreAction (in category 'actions') -----
+ completeStoreAction
+ 	"The store method will arrange for this to be called after the user has entered
+ 	a comment for the configuration version being stored."
+ 	self activeEditWindow: nil. "Close the editor window"
+ 	self pickRepository
+ 		ifNotNil: [:repo | 
+ 			configuration authorInitials: Utilities authorInitials.
+ 			configuration timeStamp: (DateAndTime fromSeconds: DateAndTime now asSeconds) printString.
+ 			configuration id: UUID new asString.
+ 			repo storeVersion: configuration.
+ 			self inform: 'Saved ', configuration name]!

Item was removed:
- ----- Method: MCConfigurationBrowser>>enterVersionComment (in category 'morphic ui') -----
- enterVersionComment
- 	^ UIManager default
- 		request: 'Comment for this configuration update'
- 		initialAnswer: (self configuration comment ifNil: ['']).
- !

Item was added:
+ ----- Method: MCConfigurationBrowser>>enterVersionCommentAndCompleteWith: (in category 'morphic ui') -----
+ enterVersionCommentAndCompleteWith: aConfigBrowser
+ 	| editWindow |
+ 	editWindow := UIManager default
+ 		edit: configuration comment
+ 		label: 'Enter or edit a comment for this configuration update'
+ 		accept: [:aText |
+ 			configuration comment: aText asString.
+ 			Project current
+ 				addDeferredUIMessage: [aConfigBrowser completeStoreAction]].
+ 	aConfigBrowser activeEditWindow: editWindow.
+ !

Item was changed:
  ----- Method: MCConfigurationBrowser>>store (in category 'actions') -----
  store
+ 	self activeEditWindow: nil. "Close previous if still open"
  	(self checkRepositories and: [self checkDependencies]) ifFalse: [^self].
  	self pickName ifNotNil: [:name |
  		configuration name: name.
+ 		self enterVersionCommentAndCompleteWith: self].!
- 		configuration comment: self enterVersionComment.
- 		self pickRepository ifNotNil: [:repo |
- 			configuration authorInitials: Utilities authorInitials.
- 			configuration timeStamp: ((DateAndTime fromSeconds: (DateAndTime now asSeconds)) printString).
- 			configuration id: UUID new asString.
- 			repo storeVersion: self configuration]].!



More information about the Squeak-dev mailing list