[squeak-dev] The Trunk: Graphics-mt.430.mcz

Marcel Taeumel marcel.taeumel at hpi.de
Mon Apr 20 06:42:33 UTC 2020


Agree. In this case, "TextColor black" works as such a "null object" for text attributes. :-) No need to add one for TextAnchor only.

Best,
Marcel
Am 18.04.2020 16:30:13 schrieb Tobias Pape <das.linux at gmx.de>:

> On 18.04.2020, at 15:37, Thiede, Christoph wrote:
>
> > + ifNil: [TextColor black "Fall back"]
>
> Do you think there would be the need for an explicit FallbackTextAttribute, which acts like a null object?

That's essentially what it is.
No need to overengineer.

Best regards
-Tobias

> Von: Squeak-dev im Auftrag von commits at source.squeak.org
> Gesendet: Freitag, 17. April 2020 16:52:44
> An: squeak-dev at lists.squeakfoundation.org; packages at lists.squeakfoundation.org
> Betreff: [squeak-dev] The Trunk: Graphics-mt.430.mcz
>
> Marcel Taeumel uploaded a new version of Graphics to project The Trunk:
> http://source.squeak.org/trunk/Graphics-mt.430.mcz
>
> ==================== Summary ====================
>
> Name: Graphics-mt.430
> Author: mt
> Time: 17 April 2020, 4:52:36.27086 pm
> UUID: 1e5eac6b-e758-8445-b60e-7b09db8dcc63
> Ancestors: Graphics-nice.429
>
> Adds a simple way to use forms as text anchors without exposing Morphic, where such anchors are currently implemented.
>
> =============== Diff against Graphics-nice.429 ===============
>
> Item was added:
> + ----- Method: Form>>asTextAnchor (in category 'converting') -----
> + asTextAnchor
> + "Convert the receiver to be embedded in text."
> +
> + self flag: #refactor. "mt: Text anchors should work outside of Morphic, too. Any instance of Form could be embedded in Text."
> + ^ (Smalltalk classNamed: 'TextAnchor')
> + ifNil: [TextColor black "Fall back"]
> + ifNotNil: [:cls | cls new anchoredMorph: self]!



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200420/4f41da25/attachment.html>


More information about the Squeak-dev mailing list