[squeak-dev] The Trunk: Kernel-dtl.1363.mcz

Eliot Miranda eliot.miranda at gmail.com
Wed Dec 9 05:39:01 UTC 2020


Hi David,

> On Dec 8, 2020, at 1:13 PM, commits at source.squeak.org wrote:
> 
> David T. Lewis uploaded a new version of Kernel to project The Trunk:
> http://source.squeak.org/trunk/Kernel-dtl.1363.mcz
> 
> ==================== Summary ====================
> 
> Name: Kernel-dtl.1363
> Author: dtl
> Time: 8 December 2020, 4:13:03.533263 pm
> UUID: dc65867e-37e6-4295-aa44-ef26c62ba250
> Ancestors: Kernel-eem.1362
> 
> Let Delay class>>startup invoke DoItFirst class>>reevaluateDebug. If a DoItFirst command line option has requested a debugger, then invoke it now after Delay startUp processing..
> 
> =============== Diff against Kernel-eem.1362 ===============
> 
> Item was changed:
>  ----- Method: Delay class>>startUp (in category 'snapshotting') -----
>  startUp
>      "Restart active delay, if any, when resuming a snapshot."
> 
>      DelaySuspended ifFalse:[^self error: 'Trying to activate Delay twice'].
>      DelaySuspended := false.
>      self restoreResumptionTimes.
>      AccessProtect signal.
> +    (Smalltalk classNamed: #DoItFirst) ifNotNil: [ :doit | doit perform: #reevaluateDebug].
> + 
> + 
>  !

I don’t understand why this is necessary/what this code does.  A comment in the startUp method would go a long way.  Also do we really need two lines of white space tacked onto the end of the method?




More information about the Squeak-dev mailing list