[squeak-dev] The Trunk: System-mt.1200.mcz

commits at source.squeak.org commits at source.squeak.org
Thu Dec 17 17:27:09 UTC 2020

Marcel Taeumel uploaded a new version of System to project The Trunk:

==================== Summary ====================

Name: System-mt.1200
Author: mt
Time: 17 December 2020, 6:27:01.501895 pm
UUID: 0ff20c8c-9b07-c546-a2fe-c8310bc4c019
Ancestors: System-mt.1199

One more tweak for SpaceTally: It does not make sense to reuse the set of seen objects when enumerating the classes. Only reuse a set when enumerating each class' instances. Now the order of classes provided for #spaceTally: does not matter anymore.

=============== Diff against System-mt.1199 ===============

Item was changed:
  ----- Method: SpaceTally>>computeSpaceUsage (in category 'class analysis') -----
- 	| seenObjects |
- 	seenObjects := self depth > 0 ifTrue: [IdentitySet new].
  		do: [ :entry |
  			| class instanceSpaceAndCount |
  			class := self class environment at: entry analyzedClassName.
  			Smalltalk garbageCollectMost.
+ 			instanceSpaceAndCount := self spaceForInstancesOf: class depth: self depth.
- 			instanceSpaceAndCount := self spaceForInstancesOf: class depth: self depth seen: seenObjects.
  				codeSize: class spaceUsed;
  				instanceCount: instanceSpaceAndCount second;
  				spaceForInstances: instanceSpaceAndCount first;
  				depthOfSpace: self depth ]
  		displayingProgress: 'Taking statistics...'!

More information about the Squeak-dev mailing list