The intended difference is that #browseVersionsOf: opens a VB on all versions of aCompiledMethod, whereas #browseMethod: selects aCompiledMethod by default. This is what #selectMethod: does.


Do you think the initial selection does not matter?


Best,

Christoph

________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Levente Uzonyi <leves at caesar.elte.hu>
Gesendet: Sonntag, 23. Februar 2020 19:40:47
An: squeak-dev at lists.squeakfoundation.org
Betreff: Re: [squeak-dev] The Inbox: Tools-ct.944.mcz

How about not adding #browseVersionsOf:, but chaging the
body of #browseMethod: to what #browseVersionsOf: is below?

^x ifNil: [ ^nil ] is the same as ^x but longer, isn't it?


Levente

On Sun, 23 Feb 2020, commits at source.squeak.org wrote:

> Christoph Thiede uploaded a new version of Tools to project The Inbox:
> http://source.squeak.org/inbox/Tools-ct.944.mcz
>
> ==================== Summary ====================
>
> Name: Tools-ct.944
> Author: ct
> Time: 23 February 2020, 5:50:43.489831 pm
> UUID: 0c54eef3-3e82-1340-9426-3e94151157d6
> Ancestors: Tools-mt.940
>
> Fixes a bug/unnecessary limitation in VersionsBrowser class >> #browseMethod: that raised an error when browsing a method that had been removed from the system.
>
> You can also reproduce it via: thisContext method browse "on a fresh image".
>
> =============== Diff against Tools-mt.940 ===============
>
> Item was changed:
>  ----- Method: VersionsBrowser class>>browseMethod: (in category 'instance creation') -----
>  browseMethod: aCompiledMethod
>
> +      ^ (self browseVersionsOf: aCompiledMethod)
> +              ifNil: [^ nil];
> -      ^ (self browseVersionsForClass: aCompiledMethod methodClass selector: aCompiledMethod selector)
>                selectMethod: aCompiledMethod;
>                yourself!
>
> Item was added:
> + ----- Method: VersionsBrowser class>>browseVersionsOf: (in category 'instance creation') -----
> + browseVersionsOf: aCompiledMethod
> +
> +      | methodClass methodSelector |
> +      methodClass := aCompiledMethod methodClass.
> +      methodSelector := aCompiledMethod selector.
> +      ^ self
> +              browseVersionsOf: aCompiledMethod
> +              class: methodClass
> +              meta: methodClass isMeta
> +              category: (methodClass organization categoryOfElement: methodSelector)
> +              selector: methodSelector!

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200223/9c1535e3/attachment-0001.html>