Hi Fabio,

I don't remember having so many new entries in the Inbox during previous 
releases. Also, I feel like this release is taking a bit too long to be 
ready.
I asked you about your commit because there are a few other "performance 
bugfixes" waiting in the Inbox, but I'm not sure if they should be pushed 
now or not.
Also, that indentity check you just added to #sameAs: could be added to 
other related comparison methods too (#compare:caseSensitive:, 
#compare:with:collated:, even to the primitive #primitiveCompareString).


Levente

On Sat, 4 Jan 2020, Fabio Niephaus wrote:

> Hi Levente,
> 
> On Fri, Jan 3, 2020 at 11:55 PM Levente Uzonyi <leves at caesar.elte.hu> wrote:
>       It's a nice improvement, but isn't it feature freeze with "only bugfixes,
>       but no new features"?
> 
> 
> I was considering this one a performance bugfix, not a new feature. Not sure how we treated these simple cases in the past.
> 
> Fabio
>  
>
>       Levente
>
>       On Fri, 3 Jan 2020, commits at source.squeak.org wrote:
>
>       > Fabio Niephaus uploaded a new version of Collections to project The Trunk:
>       > http://source.squeak.org/trunk/Collections-fn.869.mcz
>       >
>       > ==================== Summary ====================
>       >
>       > Name: Collections-fn.869
>       > Author: fn
>       > Time: 3 January 2020, 10:27:08.945712 am
>       > UUID: c29ef38b-f152-468e-bac9-74515c099ac4
>       > Ancestors: Collections-nice.868
>       >
>       > Add quick-check for identity to String>>sameAs: (similar to Character>>sameAs:).
>       >
>       > Example:
>       > [MenuIcons smallInspectItIconContents sameAs: MenuIcons smallInspectItIconContents] bench
>       >
>       > Before:
>       > 1,740,000 per second. 574 nanoseconds per run. 0 % GC time.
>       >
>       > After:
>       > 94,800,000 per second. 10.5 nanoseconds per run. 0 % GC time.
>       >
>       > =============== Diff against Collections-nice.868 ===============
>       >
>       > Item was changed:
>       >  ----- Method: String>>sameAs: (in category 'comparing') -----
>       >  sameAs: aString
>       >       "Answer whether the receiver sorts equal to aString. The
>       >       collation sequence is ascii with case differences ignored."
>       > +     self == aString ifTrue: [ ^true ].
>       >       ^(self compare: aString caseSensitive: false) = 2!
> 
> 
>