[squeak-dev] The Trunk: Collections-fn.869.mcz
asqueaker at gmail.com
Sat Jan 4 21:49:26 UTC 2020
+1 The purpose of feature freeze is to reduce risk, so if we feel
comfortable enough about a change being functionally non-impactful, IMO, it
seems fine to let it in the release. This seems pretty cut 'n' dry safe to
me, nice catch Fabio.
On Fri, Jan 3, 2020 at 5:43 PM Fabio Niephaus <lists at fniephaus.com> wrote:
> Hi Levente,
> On Fri, Jan 3, 2020 at 11:55 PM Levente Uzonyi <leves at caesar.elte.hu>
>> It's a nice improvement, but isn't it feature freeze with "only bugfixes,
>> but no new features"?
> I was considering this one a performance bugfix, not a new feature. Not
> sure how we treated these simple cases in the past.
>> On Fri, 3 Jan 2020, commits at source.squeak.org wrote:
>> > Fabio Niephaus uploaded a new version of Collections to project The
>> > http://source.squeak.org/trunk/Collections-fn.869.mcz
>> > ==================== Summary ====================
>> > Name: Collections-fn.869
>> > Author: fn
>> > Time: 3 January 2020, 10:27:08.945712 am
>> > UUID: c29ef38b-f152-468e-bac9-74515c099ac4
>> > Ancestors: Collections-nice.868
>> > Add quick-check for identity to String>>sameAs: (similar to
>> > Example:
>> > [MenuIcons smallInspectItIconContents sameAs: MenuIcons
>> smallInspectItIconContents] bench
>> > Before:
>> > 1,740,000 per second. 574 nanoseconds per run. 0 % GC time.
>> > After:
>> > 94,800,000 per second. 10.5 nanoseconds per run. 0 % GC time.
>> > =============== Diff against Collections-nice.868 ===============
>> > Item was changed:
>> > ----- Method: String>>sameAs: (in category 'comparing') -----
>> > sameAs: aString
>> > "Answer whether the receiver sorts equal to aString. The
>> > collation sequence is ascii with case differences ignored."
>> > + self == aString ifTrue: [ ^true ].
>> > ^(self compare: aString caseSensitive: false) = 2!
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Squeak-dev