[squeak-dev] The Trunk: Morphic-cmm.1617.mcz
Thiede, Christoph
Christoph.Thiede at student.hpi.uni-potsdam.de
Fri Jan 17 12:44:54 UTC 2020
1. Sorry to raise this discussion again, but shouldn't this have rather gone into two separate commits? :-)
2. > - Fix inescapable modal dialog.
Interesting. Can you give an example to reproduce?
3. > (self font widthOf: $m) * 5
Why do we hard-code this magic character here? What's so special about $m?
Best,
Christoph
________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von commits at source.squeak.org <commits at source.squeak.org>
Gesendet: Freitag, 17. Januar 2020 03:43:37
An: squeak-dev at lists.squeakfoundation.org; packages at lists.squeakfoundation.org
Betreff: [squeak-dev] The Trunk: Morphic-cmm.1617.mcz
Chris Muller uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-cmm.1617.mcz
==================== Summary ====================
Name: Morphic-cmm.1617
Author: cmm
Time: 10 January 2020, 7:32:31.635312 pm
UUID: ce0033f9-62f5-4c12-9b75-24d613d56c50
Ancestors: Morphic-tpr.1616
- Fix inescapable modal dialog.
- Fix truncation of the first line of PluggableListMorphs when a font larger than the default is used.
=============== Diff against Morphic-tpr.1616 ===============
Item was changed:
----- Method: DialogWindow>>getUserResponse (in category 'running') -----
getUserResponse
| hand world |
self message ifEmpty: [messageMorph delete]. "Do not waste space."
self paneMorph submorphs
ifEmpty: ["Do not waste space and avoid strange button-row wraps."
self paneMorph delete.
self buttonRowMorph wrapDirection: #none].
hand := self currentHand.
world := self currentWorld.
self fullBounds.
self moveToPreferredPosition.
self openInWorld: world.
hand showTemporaryCursor: nil. "Since we are out of context, reset the cursor."
hand keyboardFocus in: [:priorKeyboardFocus |
hand mouseFocus in: [:priorMouseFocus |
self exclusive ifTrue: [hand newMouseFocus: self].
hand newKeyboardFocus: self.
[[self isInWorld] whileTrue: [world doOneSubCycle]]
ifCurtailed: [self cancelDialog].
hand newKeyboardFocus: priorKeyboardFocus.
+ hand releaseMouseFocus]].
- hand newMouseFocus: priorMouseFocus]].
^ result!
Item was changed:
----- Method: PluggableListMorph>>initialize (in category 'initialization') -----
initialize
-
listMorph := self createListMorph.
super initialize.
-
self scroller
layoutPolicy: TableLayout new;
addMorph: listMorph.
+ self
+ minimumWidth: (self font widthOf: $m) * 5 ;
+ minimumHeight: self font height
- self minimumWidth: (self font widthOf: $m) * 5.
-
!
Item was changed:
----- Method: ProportionalSplitterMorph>>topBoundary (in category 'queries - geometry') -----
topBoundary
"Answer the topmost x position the receiver could be moved to."
| splitter morphs |
splitter := self splitterAbove.
morphs := self commonNeighbours: leftOrTop with: splitter.
-
^ (splitter
ifNil: [owner isSystemWindow ifTrue: [owner panelRect top]
ifFalse: [owner innerBounds top]]
ifNotNil: [splitter bottom])
+ (self minimumHeightOf: morphs)!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200117/a4378792/attachment.html>
More information about the Squeak-dev
mailing list
|