I just noticed a drawback of this approach: Open a new workspace, type foo := 6 * 7 and *debug it*. While the debugger is open, take a look at the debugger again. Of course, foo is still styled as invalid, because #expressionEvaluated:result: has not yet been called.

What do you think, would this drawback be worth another hook in #evaluateSelectionAndDo:? This additional hook could be named #expressionCompiled:, for example ...


Best,

Christoph

________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von commits at source.squeak.org <commits at source.squeak.org>
Gesendet: Mittwoch, 2. Oktober 2019 15:33:27
An: squeak-dev at lists.squeakfoundation.org; packages at lists.squeakfoundation.org
Betreff: [squeak-dev] The Trunk: Tools-ct.887.mcz

Levente Uzonyi uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-ct.887.mcz

==================== Summary ====================

Name: Tools-ct.887
Author: ct
Time: 6 September 2019, 5:14:55.984698 pm
UUID: 3f24f39e-68d7-0b45-bbb6-81299d9e9268
Ancestors: Tools-mt.886

Workspace: After expression evaluation, update style.

If you "doit-ed" an assignment, Shout colors were not updated automatically ('x := 6*7').

=============== Diff against Tools-mt.886 ===============

Item was added:
+ ----- Method: Workspace>>expressionEvaluated:result: (in category 'menu commands') -----
+ expressionEvaluated: anExpression result: anObject
+
+        self changed: #style!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200129/aa5bbf21/attachment.html>