[squeak-dev] The Inbox: Monticello-eem.709.mcz

Jakob Reschke forums.jakob at resfarm.de
Thu Jan 30 06:48:31 UTC 2020

Chris Muller <asqueaker at gmail.com> schrieb am Mi., 29. Jan. 2020, 23:40:

> On Wed, Jan 29, 2020 at 1:04 AM Jakob Reschke <forums.jakob at resfarm.de>
> wrote:
>> Chris Muller <asqueaker at gmail.com> schrieb am Mi., 29. Jan. 2020, 03:57:
>>> It's important this feature does not get inherited by SaveDialog since
>>> the functionality could be harmful if used there
>> How so? What is bad about wittingly ignoring non-changes during save? You
>> called it pollution yourself.
> Jakob, your language is confusing because "Ignore" is the other command
> there that, yes, would cause them to not be committed.
> But what is being added is a 'filter out unchanged methods from the
> list...', which, IIUC, would only remove them from the list, making them
> invisible, but not "Ignore" them.  So, if used on the Save dialog, would
> they be included in the commit?

Alright if it does not work there it should be fixed in the second
iteration of course. I didn't test it. Ignoring instead of removing on save
sounds reasonable, then you can change your mind later (although in this
case, why would you...).

I suppose this can be covered by a unit test.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200130/9db1b28a/attachment.html>

More information about the Squeak-dev mailing list