[squeak-dev] The Trunk: ShoutCore-eem.84.mcz

commits at source.squeak.org commits at source.squeak.org
Sat Jul 4 18:51:48 UTC 2020

Eliot Miranda uploaded a new version of ShoutCore to project The Trunk:

==================== Summary ====================

Name: ShoutCore-eem.84
Author: eem
Time: 4 July 2020, 11:51:47.113679 am
UUID: 56a7592a-90ef-4c61-8b03-51094781d61f
Ancestors: ShoutCore-mt.83

Shout robustness.  If anything goes wron with source file access (recursive errors in the debugger, etc) then method getSource may not answer sufficient text and a bounds violation can occur in Shout.  This prevents that.

=============== Diff against ShoutCore-mt.83 ===============

Item was changed:
  ----- Method: SHParserST80>>initializeVariablesFromContext (in category 'parse support') -----
+ 	| contextSourcePcIndex contextSource contextSourceParser |
- 	| contextSourcePcIndex contextSourceParser |
  	contextSourcePcIndex := (context debuggerMap
  		rangeForPC: (context isDead ifTrue: [context endPC] ifFalse: [context pc])
  		in: context method
  		contextIsActiveContext: true "... to really use the context's pc.")
+ 	contextSource := context method getSource.
  	contextSourceParser := self class new
  		classOrMetaClass: context method methodClass;
  		environment: self environment;
+ 		source: (contextSource first: (contextSourcePcIndex min: contextSource size));
- 		source: (context method getSource first: contextSourcePcIndex);
  	contextSourceParser parse.
  	arguments := contextSourceParser activeArguments.
+ 	temporaries  := contextSourceParser activeTemporaries!
- 	temporaries  := contextSourceParser activeTemporaries.!

More information about the Squeak-dev mailing list