[squeak-dev] The Trunk: Morphic-mt.1663.mcz

Thiede, Christoph Christoph.Thiede at student.hpi.uni-potsdam.de
Fri Jun 5 14:49:34 UTC 2020

Hi Marcel,

nice, I did not even notice these icons before! But is it really helpful to mix up meta and non-meta states here? I could imagine that an extra class icon might be more helpful when you are debugging something and are wondering "whether this object here is lacking its instance variables but has superclass etc. instead". Just my two cents :-)

Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von commits at source.squeak.org <commits at source.squeak.org>
Gesendet: Freitag, 5. Juni 2020 10:02:11
An: squeak-dev at lists.squeakfoundation.org; packages at lists.squeakfoundation.org
Betreff: [squeak-dev] The Trunk: Morphic-mt.1663.mcz

Marcel Taeumel uploaded a new version of Morphic to project The Trunk:

==================== Summary ====================

Name: Morphic-mt.1663
Author: mt
Time: 5 June 2020, 10:02:07.727634 am
UUID: a4b01b68-1ce2-8548-8a33-df76f33a3a89
Ancestors: Morphic-mt.1662

Minor fix for class icons in object explorers. If you happen to actually explore the class, not just instances of it, show that icon, too.

=============== Diff against Morphic-mt.1662 ===============

Item was changed:
  ----- Method: ObjectExplorerWrapper>>icon (in category 'accessing') -----
         "Answer a form to be used as icon"
         ^ Preferences visualExplorer
                 ifTrue: [([self object iconOrThumbnailOfSize: 12] on: Error do: [nil])
                         ifNil: [self class showClassIcons
+                                ifTrue: [ToolIcons iconNamed: self object class theNonMetaClass toolIcon]
-                                ifTrue: [ToolIcons iconNamed: self object class toolIcon]
                                 ifFalse: [self class showContentsInColumns
                                         ifTrue: [ToolIcons iconNamed: #blank]
                                         ifFalse: [nil]]]]
                 ifFalse: [nil]!

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200605/b3a9f7b9/attachment.html>

More information about the Squeak-dev mailing list