[squeak-dev] The Inbox: Monticello-jr.722.mcz

commits at source.squeak.org commits at source.squeak.org
Mon Jun 8 20:13:20 UTC 2020


A new version of Monticello was added to project The Inbox:
http://source.squeak.org/inbox/Monticello-jr.722.mcz

==================== Summary ====================

Name: Monticello-jr.722
Author: jr
Time: 8 June 2020, 10:13:23.034513 pm
UUID: 7062dfdb-583b-4d46-b37d-91a3781db5b9
Ancestors: Monticello-jr.721

Log method changes only if the SystemChangeNotifer is not muted.

unload is already routed through ClassDescription>>removeSelector: which emits a system change event rather than writing to the log unconditionally.

This change is useful to avoid cluttering the changes file when tests are run that load methods via Monticello. Previously even if these tests muted the change notifications, Monticello loading would still write lots of change records.

=============== Diff against Monticello-jr.721 ===============

Item was changed:
  ----- Method: MCMethodDefinition>>asMethodAddition (in category 'converting') -----
  asMethodAddition
  	^MethodAddition new
  		compile: source
  		classified: category
  		withStamp: timeStamp
  		notifying: nil
+ 		logSource: SystemChangeNotifier uniqueInstance isBroadcasting
- 		logSource: true
  		inClass: self actualClass.!

Item was changed:
  ----- Method: MCMethodDefinition>>load (in category 'accessing') -----
  load
+ 	| class |
+ 	class := self actualClass.
+ 	class
- 	self actualClass
  		compile: source
  		classified: category
  		withStamp: timeStamp
+ 		notifying: nil
+ 		logSource: (SystemChangeNotifier uniqueInstance isBroadcasting and: [class acceptsLoggingOfCompilation])!
- 		notifying: nil!



More information about the Squeak-dev mailing list