[squeak-dev] The Trunk: Monticello-jr.722.mcz

commits at source.squeak.org commits at source.squeak.org
Tue Jun 9 13:17:56 UTC 2020

Marcel Taeumel uploaded a new version of Monticello to project The Trunk:

==================== Summary ====================

Name: Monticello-jr.722
Author: jr
Time: 8 June 2020, 10:13:23.034513 pm
UUID: 7062dfdb-583b-4d46-b37d-91a3781db5b9
Ancestors: Monticello-jr.721

Log method changes only if the SystemChangeNotifer is not muted.

unload is already routed through ClassDescription>>removeSelector: which emits a system change event rather than writing to the log unconditionally.

This change is useful to avoid cluttering the changes file when tests are run that load methods via Monticello. Previously even if these tests muted the change notifications, Monticello loading would still write lots of change records.

=============== Diff against Monticello-mt.719 ===============

Item was changed:
  ----- Method: MCClassDefinition>>requirements (in category 'comparing') -----
  	^superclassName == #nil
  		ifTrue: [self poolDictionaries]
+ 		ifFalse: [{ superclassName }, self poolDictionaries,
+ 			(self hasTraitComposition
+ 				ifTrue: [(Scanner new scanTokens: self traitComposition) flattened select: [:each | each first isUppercase]]
+ 				ifFalse: [#()])].!
- 		ifFalse: [{ superclassName }, self poolDictionaries]!

Item was changed:
  ----- Method: MCClassTraitDefinition>>load (in category 'installing') -----
+ 	Compiler evaluate: self definitionString environment: Environment current!
- 	Compiler evaluate: self definitionString!

Item was changed:
  ----- Method: MCMethodDefinition>>asMethodAddition (in category 'converting') -----
  	^MethodAddition new
  		compile: source
  		classified: category
  		withStamp: timeStamp
  		notifying: nil
+ 		logSource: SystemChangeNotifier uniqueInstance isBroadcasting
- 		logSource: true
  		inClass: self actualClass.!

Item was changed:
  ----- Method: MCMethodDefinition>>load (in category 'accessing') -----
+ 	| class |
+ 	class := self actualClass.
+ 	class
- 	self actualClass
  		compile: source
  		classified: category
  		withStamp: timeStamp
+ 		notifying: nil
+ 		logSource: (SystemChangeNotifier uniqueInstance isBroadcasting and: [class acceptsLoggingOfCompilation])!
- 		notifying: nil!

Item was changed:
  ----- Method: MCScriptDefinition>>evaluate (in category 'installing') -----
+ 	Compiler evaluate: script environment: Environment current!
- 	Compiler evaluate: script!

More information about the Squeak-dev mailing list