[squeak-dev] The Inbox: ToolBuilder-MVC-ct.60.mcz

commits at source.squeak.org commits at source.squeak.org
Sat Jun 27 20:37:04 UTC 2020

Christoph Thiede uploaded a new version of ToolBuilder-MVC to project The Inbox:

==================== Summary ====================

Name: ToolBuilder-MVC-ct.60
Author: ct
Time: 27 June 2020, 10:37:01.784959 pm
UUID: dd09ecec-d16e-854c-8564-d21576eb58fc
Ancestors: ToolBuilder-MVC-mt.59

Don't fail in MVCToolBuilder when opening a menu

The semantics of ToolBuilder >> #open: are to work regardless of the build state of the passed object (thus "anObject"). As a consequence, [MVCToolBuilder new open: (MVCToolBuilder new build: PluggableMenuSpec new)] should work, too.

=============== Diff against ToolBuilder-MVC-mt.59 ===============

Item was changed:
  ----- Method: MVCToolBuilder>>open: (in category 'opening') -----
  open: anObject
  	"Build and open the object. Answer the widget opened."
  	| window |
+ 	window := (anObject isKindOf: View orOf: PopUpMenu)
- 	window := (anObject isKindOf: View)
  		ifTrue: [anObject]
  		ifFalse: [self build: anObject].
  	(window isKindOf: PopUpMenu)
  		ifTrue: [window invokeOn: nil].
  	(window isKindOf: View)
  		ifTrue: [window controller open].

More information about the Squeak-dev mailing list