> Ok and Cancel imply a modal color picker, I'd rather keep it non-modal with multiple 'Undo' as the preferred way to "cancel" prior selections.  I don't want to "Close" it until I'm ready to, and a Close is just right for that.


+1


> I didn't look at the code in detail, so don't know if there's some practical limitation which disrupts that, if so, please ignore and pardon me.  :)

The NCPM does not use stepping. It uses an observer pattern - see #selectedColor:, #colorSelected:, and #targetColor: :)

> I was thinking a list of "prior selections" in a slide-out drawer (or, wherever).  It would be preloaded with the first one which would be the original "from" color (Cancel functionality)...

Wow-wow! This proposal sounds indeed interesting as a general concept (one might use it as well for editors or morph operations, for example), but a few numbers larger than the current change. I will be excited to study your changesets/commits about it! But I would not make this commit - the picking button - dependent on such a history slider :-)

Best,
Christoph

________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Chris Muller <ma.chris.m at gmail.com>
Gesendet: Montag, 2. März 2020 22:10:35
An: karl ramberg
Cc: The general-purpose Squeak developers list
Betreff: Re: [squeak-dev] The Inbox: Morphic-ct.1634.mcz

I was thinking a list of "prior selections" in a slide-out drawer (or, wherever).  It would be preloaded with the first one which would be the original "from" color (Cancel functionality)...

On Mon, Mar 2, 2020 at 3:04 PM karl ramberg <karlramberg at gmail.com<mailto:karlramberg at gmail.com>> wrote:
So maybe an explicit undo button then ?

Best,
Karl


On Sun, Mar 1, 2020 at 11:00 PM Chris Muller <asqueaker at gmail.com<mailto:asqueaker at gmail.com>> wrote:
Hi Christoph,

@Subbu: I value your argument, it's just the morph being recolored not really looking nice during moving your cursor when picking is enabled. Let's wait some time for others' opinions :)

I agree with you about the usability aspect, and with Subbu about the implementation of a new instVar if the same could be accomplished by simply telling it to #stopStepping entirely once Pick is clicked.  Then #startStepping again after pickage or whenever appropriate..

I didn't look at the code in detail, so don't know if there's some practical limitation which disrupts that, if so, please ignore and pardon me.  :)

Best,
  Chris



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200303/a8eeb12c/attachment.html>