[squeak-dev] The Trunk: Tools-ct.945.mcz

commits at source.squeak.org commits at source.squeak.org
Thu Mar 5 11:46:22 UTC 2020

Nicolas Cellier uploaded a new version of Tools to project The Trunk:

==================== Summary ====================

Name: Tools-ct.945
Author: ct
Time: 24 February 2020, 1:56:51.392323 pm
UUID: cc577466-ca48-484b-9454-11ae7ffde0b2
Ancestors: Tools-mt.940

Fixes a bug/unnecessary limitation in VersionsBrowser class >> #browseMethod: that raised an error when browsing a method that had been removed from the system.

You can also reproduce it via: thisContext method browse "on a fresh image".

This commit replaces Tools-ct.944, which has been refactored again to reuse the return carat according to Kent Beck ("Format conditionals so their value is used where it clearly expresses the intent of the method"). Thanks to Chris for the reminder!

=============== Diff against Tools-mt.940 ===============

Item was changed:
  ----- Method: VersionsBrowser class>>browseMethod: (in category 'instance creation') -----
  browseMethod: aCompiledMethod
+ 	^ (self browseVersionsOf: aCompiledMethod)
+ 		ifNotNil: [:browser |
+ 			browser selectMethod: aCompiledMethod];
- 	^ (self browseVersionsForClass: aCompiledMethod methodClass selector: aCompiledMethod selector)
- 		selectMethod: aCompiledMethod;

Item was added:
+ ----- Method: VersionsBrowser class>>browseVersionsOf: (in category 'instance creation') -----
+ browseVersionsOf: aCompiledMethod
+ 	| methodClass methodSelector |
+ 	methodClass := aCompiledMethod methodClass.
+ 	methodSelector := aCompiledMethod selector.
+ 	^ self
+ 		browseVersionsOf: aCompiledMethod
+ 		class: methodClass
+ 		meta: methodClass isMeta
+ 		category: (methodClass organization categoryOfElement: methodSelector)
+ 		selector: methodSelector!

More information about the Squeak-dev mailing list