Hi Christoph,

no worries. This was just an observation. Maybe the next time we touch that class, we can improve the code.

Best,
Marcel
Am 07.10.2020 13:56:17 schrieb Thiede, Christoph <christoph.thiede at student.hpi.uni-potsdam.de>:
Would you like me to rename it or is this not worth the effort? :-)

Best,
Christoph
[http://www.hpi.de/]
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel
Gesendet: Mittwoch, 7. Oktober 2020 09:11:53
An: squeak-dev
Betreff: Re: [squeak-dev] The Inbox: Morphic-ct.1691.mcz
 
Hehe. "aMorph" is a good example for unfortunate naming. Took me a while to figure out that the "a" stands for "alpha" after reading the list of inst vars: hsvMorph, aMorph :-D

Best,
Marcel
Am 01.10.2020 02:50:29 schrieb commits at source.squeak.org <commits at source.squeak.org>:
Christoph Thiede uploaded a new version of Morphic to project The Inbox:
http://source.squeak.org/inbox/Morphic-ct.1691.mcz

==================== Summary ====================

Name: Morphic-ct.1691
Author: ct
Time: 1 October 2020, 2:50:08.612807 am
UUID: f9f5e618-2e8a-3f4b-a1f8-1c9aca2b5f01
Ancestors: Morphic-eem.1686

Fixes alpha selection strip in HSVA color selector, which has always lived one click back in past.

=============== Diff against Morphic-eem.1686 ===============

Item was changed:
----- Method: HSVAColorSelectorMorph>>alphaSelected: (in category 'accessing') -----
alphaSelected: aFloat
"The alpha has changed."

+ self aMorph value: aFloat.
self triggerSelectedColor!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20201008/61d4a50f/attachment.html>